Browse code

Fix several typos

Thanks to https://github.com/rhcarvalho/typokiller

Rodolfo Carvalho authored on 2015/02/14 21:33:22
Showing 30 changed files
... ...
@@ -15,7 +15,7 @@ func RegisterMimeTypes() {
15 15
 	registerIfNeeded(".png", "image/png")
16 16
 	registerIfNeeded(".svg", "image/svg+xml")
17 17
 
18
-	// Javascript types
18
+	// JavaScript types
19 19
 	registerIfNeeded(".js", "application/javascript; charset=utf-8")
20 20
 	registerIfNeeded(".json", "application/json; charset=utf-8")
21 21
 
... ...
@@ -10,14 +10,14 @@ import (
10 10
 	oauthapi "github.com/openshift/origin/pkg/oauth/api"
11 11
 )
12 12
 
13
-// unionAuthenticationHandler is an oauth.AuthenticationHandler that muxes multiple challange handlers and redirect handlers
13
+// unionAuthenticationHandler is an oauth.AuthenticationHandler that muxes multiple challenge handlers and redirect handlers
14 14
 type unionAuthenticationHandler struct {
15 15
 	challengers  map[string]AuthenticationChallenger
16 16
 	redirectors  map[string]AuthenticationRedirector
17 17
 	errorHandler AuthenticationErrorHandler
18 18
 }
19 19
 
20
-// NewUnionAuthenticationHandler returns an oauth.AuthenticationHandler that muxes multiple challange handlers and redirect handlers
20
+// NewUnionAuthenticationHandler returns an oauth.AuthenticationHandler that muxes multiple challenge handlers and redirect handlers
21 21
 func NewUnionAuthenticationHandler(passedChallengers map[string]AuthenticationChallenger, passedRedirectors map[string]AuthenticationRedirector, errorHandler AuthenticationErrorHandler) AuthenticationHandler {
22 22
 	challengers := passedChallengers
23 23
 	if challengers == nil {
... ...
@@ -10,7 +10,7 @@ import (
10 10
 
11 11
 // Registry is an interface for things that know how to store Policies.
12 12
 type Registry interface {
13
-	// ListPolicies obtains list of policys that match a selector.
13
+	// ListPolicies obtains list of policies that match a selector.
14 14
 	ListPolicies(ctx kapi.Context, labels, fields klabels.Selector) (*authorizationapi.PolicyList, error)
15 15
 	// GetPolicy retrieves a specific policy.
16 16
 	GetPolicy(ctx kapi.Context, id string) (*authorizationapi.Policy, error)
... ...
@@ -128,7 +128,7 @@ func doesRoleExist(name string, policy *authorizationapi.Policy) bool {
128 128
 	return exists
129 129
 }
130 130
 
131
-// EnsurePOlicy returns the policy object for the specified namespace.  If one does not exist, it is created for you.  Permission to
131
+// EnsurePolicy returns the policy object for the specified namespace.  If one does not exist, it is created for you.  Permission to
132 132
 // create, update, or delete roles in a namespace implies the ability to create a Policy object itself.
133 133
 func (r *REST) EnsurePolicy(ctx kapi.Context) (*authorizationapi.Policy, error) {
134 134
 	policy, err := r.registry.GetPolicy(ctx, authorizationapi.PolicyName)
... ...
@@ -18,7 +18,7 @@ type PolicyRegistry struct {
18 18
 	DeletedPolicyName string
19 19
 }
20 20
 
21
-// ListPolicies obtains list of policys that match a selector.
21
+// ListPolicies obtains list of policies that match a selector.
22 22
 func (r *PolicyRegistry) ListPolicies(ctx kapi.Context, labels, fields klabels.Selector) (*authorizationapi.PolicyList, error) {
23 23
 	if r.Err != nil {
24 24
 		return nil, r.Err
... ...
@@ -99,7 +99,7 @@ type GitSourceRevision struct {
99 99
 	// Author is the author of a specific commit
100 100
 	Author SourceControlUser `json:"author,omitempty"`
101 101
 
102
-	// Committer is the commiter of a specific commit
102
+	// Committer is the committer of a specific commit
103 103
 	Committer SourceControlUser `json:"committer,omitempty"`
104 104
 
105 105
 	// Message is the description of a specific commit
... ...
@@ -277,7 +277,7 @@ type BuildTriggerPolicy struct {
277 277
 	// Type is the type of build trigger
278 278
 	Type BuildTriggerType `json:"type,omitempty"`
279 279
 
280
-	// GithubWebHook contains the parameters for a Github webhook type of trigger
280
+	// GithubWebHook contains the parameters for a GitHub webhook type of trigger
281 281
 	GithubWebHook *WebHookTrigger `json:"github,omitempty"`
282 282
 
283 283
 	// GenericWebHook contains the parameters for a Generic webhook type of trigger
... ...
@@ -292,7 +292,7 @@ type BuildTriggerType string
292 292
 
293 293
 const (
294 294
 	// GithubWebHookBuildTriggerType represents a trigger that launches builds on
295
-	// Github webhook invocations
295
+	// GitHub webhook invocations
296 296
 	GithubWebHookBuildTriggerType BuildTriggerType = "github"
297 297
 
298 298
 	// GenericWebHookBuildTriggerType represents a trigger that launches builds on
... ...
@@ -99,7 +99,7 @@ type GitSourceRevision struct {
99 99
 	// Author is the author of a specific commit
100 100
 	Author SourceControlUser `json:"author,omitempty"`
101 101
 
102
-	// Committer is the commiter of a specific commit
102
+	// Committer is the committer of a specific commit
103 103
 	Committer SourceControlUser `json:"committer,omitempty"`
104 104
 
105 105
 	// Message is the description of a specific commit
... ...
@@ -285,7 +285,7 @@ type BuildTriggerPolicy struct {
285 285
 	// Type is the type of build trigger
286 286
 	Type BuildTriggerType `json:"type,omitempty"`
287 287
 
288
-	// GithubWebHook contains the parameters for a Github webhook type of trigger
288
+	// GithubWebHook contains the parameters for a GitHub webhook type of trigger
289 289
 	GithubWebHook *WebHookTrigger `json:"github,omitempty"`
290 290
 
291 291
 	// GenericWebHook contains the parameters for a Generic webhook type of trigger
... ...
@@ -300,7 +300,7 @@ type BuildTriggerType string
300 300
 
301 301
 const (
302 302
 	// GithubWebHookBuildTriggerType represents a trigger that launches builds on
303
-	// Github webhook invocations
303
+	// GitHub webhook invocations
304 304
 	GithubWebHookBuildTriggerType BuildTriggerType = "github"
305 305
 
306 306
 	// GenericWebHookBuildTriggerType represents a trigger that launches builds on
... ...
@@ -1,3 +1,3 @@
1
-// Package builder contains builders for STI and Docker in Openshift Origin
1
+// Package builder contains builders for STI and Docker in OpenShift Origin
2 2
 
3 3
 package builder
... ...
@@ -18,7 +18,7 @@ import (
18 18
 )
19 19
 
20 20
 // urlCheckTimeout is the timeout used to check the source URL
21
-// If fetching the URL exceeeds the timeout, then the build will
21
+// If fetching the URL exceeds the timeout, then the build will
22 22
 // not proceed further and stop
23 23
 const urlCheckTimeout = 16 * time.Second
24 24
 
... ...
@@ -263,7 +263,7 @@ func TestNoImageIDChange(t *testing.T) {
263 263
 }
264 264
 
265 265
 func TestBuildCreateError(t *testing.T) {
266
-	// valid configuration, but build creation failes, in that situation the buildconfig should not be updated
266
+	// valid configuration, but build creation fails, in that situation the buildconfig should not be updated
267 267
 	buildcfg := mockBuildConfig("registry.com/namespace/imagename", "registry.com/namespace/imagename", "testImageRepo", "testTag")
268 268
 	controller := mockImageChangeController(buildcfg, "testImageRepo", "registry.com/namespace/imagename", map[string]string{"testTag": "newImageID123"})
269 269
 	buildCreator := controller.BuildCreator.(*mockBuildCreator)
... ...
@@ -76,7 +76,7 @@ func (c *builds) Delete(name string) (err error) {
76 76
 	return
77 77
 }
78 78
 
79
-// Watch returns a watch.Interfac that watches the requested builds
79
+// Watch returns a watch.Interface that watches the requested builds
80 80
 func (c *builds) Watch(label, field labels.Selector, resourceVersion string) (watch.Interface, error) {
81 81
 	return c.r.Get().
82 82
 		Prefix("watch").
... ...
@@ -4,7 +4,7 @@ import (
4 4
 	userapi "github.com/openshift/origin/pkg/user/api"
5 5
 )
6 6
 
7
-// FakeUserss implements BuildInterface. Meant to be embedded into a struct to get a default
7
+// FakeUsers implements BuildInterface. Meant to be embedded into a struct to get a default
8 8
 // implementation. This makes faking out just the methods you want to test easier.
9 9
 type FakeUsers struct {
10 10
 	Fake *Fake
... ...
@@ -41,7 +41,7 @@ func newImageRepositories(c *Client, namespace string) *imageRepositories {
41 41
 	}
42 42
 }
43 43
 
44
-// List returns a list of imagerepositories that match the label and fiels selectors.
44
+// List returns a list of imagerepositories that match the label and field selectors.
45 45
 func (c *imageRepositories) List(label, field labels.Selector) (result *imageapi.ImageRepositoryList, err error) {
46 46
 	result = &imageapi.ImageRepositoryList{}
47 47
 	err = c.r.Get().
... ...
@@ -206,11 +206,11 @@ type AuthConfig struct {
206 206
 	// GoogleClientID is the client_secret of a client registered with the Google OAuth provider.
207 207
 	GoogleClientSecret string
208 208
 
209
-	// GithubClientID is the client_id of a client registered with the Github OAuth provider.
209
+	// GithubClientID is the client_id of a client registered with the GitHub OAuth provider.
210 210
 	// It must be authorized to redirect to {MasterPublicAddr}/oauth2callback/github
211 211
 	// Used by AuthHandlerGithub
212 212
 	GithubClientID string
213
-	// GithubClientID is the client_secret of a client registered with the Github OAuth provider.
213
+	// GithubClientID is the client_secret of a client registered with the GitHub OAuth provider.
214 214
 	GithubClientSecret string
215 215
 }
216 216
 
... ...
@@ -414,7 +414,7 @@ func (c *AuthConfig) getAuthenticationFinalizer() osinserver.AuthorizeHandler {
414 414
 func (c *AuthConfig) getAuthenticationHandler(mux cmdutil.Mux, errorHandler handlers.AuthenticationErrorHandler) handlers.AuthenticationHandler {
415 415
 	successHandler := c.getAuthenticationSuccessHandler()
416 416
 
417
-	// TODO presumeably we'll want either a list of what we've got or a way to describe a registry of these
417
+	// TODO presumably we'll want either a list of what we've got or a way to describe a registry of these
418 418
 	// hard-coded strings as a stand-in until it gets sorted out
419 419
 	var authHandler handlers.AuthenticationHandler
420 420
 	authHandlerType := c.AuthHandler
... ...
@@ -458,7 +458,7 @@ func (c *AuthConfig) getAuthenticationHandler(mux cmdutil.Mux, errorHandler hand
458 458
 }
459 459
 
460 460
 func (c *AuthConfig) getPasswordAuthenticator() authenticator.Password {
461
-	// TODO presumeably we'll want either a list of what we've got or a way to describe a registry of these
461
+	// TODO presumably we'll want either a list of what we've got or a way to describe a registry of these
462 462
 	// hard-coded strings as a stand-in until it gets sorted out
463 463
 	passwordAuthType := c.PasswordAuth
464 464
 	userRegistry := useretcd.New(c.EtcdHelper, user.NewDefaultUserInitStrategy())
... ...
@@ -504,7 +504,7 @@ func (c *AuthConfig) getAuthenticationSuccessHandler() handlers.AuthenticationSu
504 504
 }
505 505
 
506 506
 func (c *AuthConfig) getAuthenticationRequestHandlerFromType(authRequestHandlerType AuthRequestHandlerType) authenticator.Request {
507
-	// TODO presumeably we'll want either a list of what we've got or a way to describe a registry of these
507
+	// TODO presumably we'll want either a list of what we've got or a way to describe a registry of these
508 508
 	// hard-coded strings as a stand-in until it gets sorted out
509 509
 	var authRequestHandler authenticator.Request
510 510
 	switch authRequestHandlerType {
... ...
@@ -545,7 +545,7 @@ func (c *AuthConfig) getAuthenticationRequestHandlerFromType(authRequestHandlerT
545 545
 }
546 546
 
547 547
 func (c *AuthConfig) getAuthenticationRequestHandler() authenticator.Request {
548
-	// TODO presumeably we'll want either a list of what we've got or a way to describe a registry of these
548
+	// TODO presumably we'll want either a list of what we've got or a way to describe a registry of these
549 549
 	// hard-coded strings as a stand-in until it gets sorted out
550 550
 	var authRequestHandlers []authenticator.Request
551 551
 	for _, requestHandler := range c.AuthRequestHandlers {
... ...
@@ -368,7 +368,7 @@ func (c *MasterConfig) InstallUnprotectedAPI(container *restful.Container) []str
368 368
 	return []string{}
369 369
 }
370 370
 
371
-//initAPIVersionRoute initializes the osapi endpoint to behave similiar to the upstream api endpoint
371
+//initAPIVersionRoute initializes the osapi endpoint to behave similar to the upstream api endpoint
372 372
 func initAPIVersionRoute(root *restful.WebService, version string) {
373 373
 	versionHandler := apiserver.APIVersionHandler(version)
374 374
 	root.Route(root.GET(OpenShiftAPIPrefix).To(versionHandler).
... ...
@@ -442,12 +442,12 @@ func start(cfg *config, args []string) error {
442 442
 			// Bootstrap clients
443 443
 			osClientConfigTemplate := kclient.Config{Host: cfg.MasterAddr.URL.String(), Version: latest.Version}
444 444
 
445
-			// Openshift client
445
+			// OpenShift client
446 446
 			openshiftClientUser := &user.DefaultInfo{Name: "system:openshift-client"}
447 447
 			if osmaster.OSClientConfig, err = ca.MakeClientConfig("openshift-client", openshiftClientUser, osClientConfigTemplate); err != nil {
448 448
 				return err
449 449
 			}
450
-			// Openshift deployer client
450
+			// OpenShift deployer client
451 451
 			openshiftDeployerUser := &user.DefaultInfo{Name: "system:openshift-deployer", Groups: []string{"system:deployers"}}
452 452
 			if osmaster.DeployerOSClientConfig, err = ca.MakeClientConfig("openshift-deployer", openshiftDeployerUser, osClientConfigTemplate); err != nil {
453 453
 				return err
... ...
@@ -543,7 +543,7 @@ func start(cfg *config, args []string) error {
543 543
 			// Google config
544 544
 			GoogleClientID:     env("OPENSHIFT_OAUTH_GOOGLE_CLIENT_ID", ""),
545 545
 			GoogleClientSecret: env("OPENSHIFT_OAUTH_GOOGLE_CLIENT_SECRET", ""),
546
-			// Github config
546
+			// GitHub config
547 547
 			GithubClientID:     env("OPENSHIFT_OAUTH_GITHUB_CLIENT_ID", ""),
548 548
 			GithubClientSecret: env("OPENSHIFT_OAUTH_GITHUB_CLIENT_SECRET", ""),
549 549
 		}
... ...
@@ -28,7 +28,7 @@ type Deployment struct {
28 28
 	Details *DeploymentDetails `json:"details,omitempty"`
29 29
 }
30 30
 
31
-// DeploymentStatus decribes the possible states a deployment can be in.
31
+// DeploymentStatus describes the possible states a deployment can be in.
32 32
 type DeploymentStatus string
33 33
 
34 34
 const (
... ...
@@ -29,7 +29,7 @@ type Deployment struct {
29 29
 	Details *DeploymentDetails `json:"details,omitempty"`
30 30
 }
31 31
 
32
-// DeploymentStatus decribes the possible states a deployment can be in.
32
+// DeploymentStatus describes the possible states a deployment can be in.
33 33
 type DeploymentStatus string
34 34
 
35 35
 const (
... ...
@@ -212,7 +212,7 @@ func TestImageChangeMatchScenarios(t *testing.T) {
212 212
 		t.Logf("running scenario: %v", s)
213 213
 		controller.HandleImageRepo()
214 214
 
215
-		// assert updates/generations occured
215
+		// assert updates/generations occurred
216 216
 		if s.matches && !updated {
217 217
 			t.Fatalf("expected update for scenario: %v", s)
218 218
 		}
... ...
@@ -137,7 +137,7 @@ type WeightedResolver struct {
137 137
 // PerfectMatchWeightedResolver returns only matches from resolvers that are identified as exact
138 138
 // (weight 0.0), and only matches from those resolvers that qualify as exact (score = 0.0). If no
139 139
 // perfect matches exist, an ErrMultipleMatches is returned indicating the remaining candidate(s).
140
-// Note that this metchod may resolve ErrMultipleMatches with a single match, indicating an error
140
+// Note that this method may resolve ErrMultipleMatches with a single match, indicating an error
141 141
 // (no perfect match) but with only one candidate.
142 142
 type PerfectMatchWeightedResolver []WeightedResolver
143 143
 
... ...
@@ -9,7 +9,7 @@ import (
9 9
 
10 10
 func init() {
11 11
 	err := kapi.Scheme.AddConversionFuncs(
12
-		// The docker metadat must be cast to a version
12
+		// The docker metadata must be cast to a version
13 13
 		func(in *newer.Image, out *Image, s conversion.Scope) error {
14 14
 			if err := s.Convert(&in.ObjectMeta, &out.ObjectMeta, 0); err != nil {
15 15
 				return err
... ...
@@ -38,7 +38,7 @@ type Parameter struct {
38 38
 	From string `json:"from,omitempty"`
39 39
 
40 40
 	// Optional: Value holds the Parameter data. The Value data can be
41
-	// overwritten by the generator. The value replaces all occurances
41
+	// overwritten by the generator. The value replaces all occurrences
42 42
 	// of the Parameter ${Name} expression during the Template to Config
43 43
 	// transformation.
44 44
 	Value string `json:"value,omitempty"`
... ...
@@ -39,7 +39,7 @@ type Parameter struct {
39 39
 	From string `json:"from,omitempty"`
40 40
 
41 41
 	// Optional: Value holds the Parameter data. The Value data can be
42
-	// overwritten by the generator. The value replaces all occurances
42
+	// overwritten by the generator. The value replaces all occurrences
43 43
 	// of the Parameter ${Name} expression during the Template to Config
44 44
 	// transformation.
45 45
 	Value string `json:"value,omitempty"`
... ...
@@ -82,7 +82,7 @@ func alphabetSlice(from, to byte) (string, error) {
82 82
 	return ASCII[leftPos:rightPos], nil
83 83
 }
84 84
 
85
-// replaceWithGenerated replaces all occurences of the given expression
85
+// replaceWithGenerated replaces all occurrences of the given expression
86 86
 // in the string with random characters of the specified range and length.
87 87
 func replaceWithGenerated(s *string, expression string, ranges [][]byte, length int, seed *rand.Rand) error {
88 88
 	var alphabet string
... ...
@@ -36,7 +36,7 @@ func NewProcessor(generators map[string]Generator) *Processor {
36 36
 
37 37
 // Process transforms Template object into List object. It generates
38 38
 // Parameter values using the defined set of generators first, and then it
39
-// substitutes all Parameter expression occurances with their corresponding
39
+// substitutes all Parameter expression occurrences with their corresponding
40 40
 // values (currently in the containers' Environment variables only).
41 41
 func (p *Processor) Process(template *api.Template) (*configapi.Config, errs.ValidationErrorList) {
42 42
 	templateErrors := errs.ValidationErrorList{}
... ...
@@ -85,7 +85,7 @@ func GetParameterByName(t *api.Template, name string) *api.Parameter {
85 85
 
86 86
 // SubstituteParameters loops over all Environment variables defined for
87 87
 // all ReplicationController and Pod containers and substitutes all
88
-// Parameter expression occurances with their corresponding values.
88
+// Parameter expression occurrences with their corresponding values.
89 89
 //
90 90
 // Example of Parameter expression:
91 91
 //   - ${PARAMETER_NAME}
... ...
@@ -119,7 +119,7 @@ func (p *Processor) SubstituteParameters(params []api.Parameter, item runtime.Ob
119 119
 
120 120
 // substituteParametersInManifest is a helper function that iterates
121 121
 // over the given manifest and substitutes all Parameter expression
122
-// occurances with their corresponding values.
122
+// occurrences with their corresponding values.
123 123
 func (p *Processor) substituteParametersInManifest(containers []kapi.Container, paramMap map[string]string) {
124 124
 	for i := range containers {
125 125
 		for e := range containers[i].Env {
... ...
@@ -110,7 +110,7 @@ func TestEtcdUpdateUserIdentityMappingWithConflictingUser(t *testing.T) {
110 110
 			ObjectMeta: kapi.ObjectMeta{Name: "yankee:xray"},
111 111
 		},
112 112
 	}
113
-	// this key is intentionally wrong so that we can have an internally consistend UserIdentityMapping
113
+	// this key is intentionally wrong so that we can have an internally consistent UserIdentityMapping
114 114
 	// that was placed in a bad key location
115 115
 	key := makeTestUserIdentityMapping("zulu", "alfa")
116 116
 	fakeClient.Set(key, runtime.EncodeOrDie(latest.Codec, startingMapping), 0)
... ...
@@ -2,7 +2,7 @@ package util
2 2
 
3 3
 import "sort"
4 4
 
5
-// UniqueStrings returns a sorted, uniqified slice of the specified strings
5
+// UniqueStrings returns a sorted, uniquified slice of the specified strings
6 6
 func UniqueStrings(strings []string) []string {
7 7
 	m := make(map[string]bool, len(strings))
8 8
 	for _, s := range strings {
... ...
@@ -20,7 +20,7 @@ type TemplatePlugin struct {
20 20
 
21 21
 // router controls the interaction of the plugin with the underlying router implementation
22 22
 type router interface {
23
-	// Mutative operations in this interfance do not return errors.
23
+	// Mutative operations in this interface do not return errors.
24 24
 	// The only error state for these methods is when an unknown
25 25
 	// frontend key is used; all call sites make certain the frontend
26 26
 	// is created.
... ...
@@ -43,7 +43,7 @@ func (r *TestRouter) FindServiceUnit(id string) (v ServiceUnit, ok bool) {
43 43
 	return
44 44
 }
45 45
 
46
-// AddEndpoints adds the endpoints to the serivce unit identified by id
46
+// AddEndpoints adds the endpoints to the service unit identified by id
47 47
 func (r *TestRouter) AddEndpoints(id string, endpoints []Endpoint) {
48 48
 	r.Committed = false //expect any call to this method to subsequently call commit
49 49
 	su, _ := r.FindServiceUnit(id)
... ...
@@ -82,7 +82,7 @@ func (r *TestRouter) AddRoute(id string, route *routeapi.Route) {
82 82
 	r.State[id] = su
83 83
 }
84 84
 
85
-// RemoveRoute removes the serivce alias config for Route from the ServiceUnit
85
+// RemoveRoute removes the service alias config for Route from the ServiceUnit
86 86
 func (r *TestRouter) RemoveRoute(id string, route *routeapi.Route) {
87 87
 	r.Committed = false //expect any call to this method to subsequently call commit
88 88
 	if _, ok := r.State[id]; !ok {
... ...
@@ -27,7 +27,7 @@ func init() {
27 27
 
28 28
 // TestRouter is the table based test for routers.  It will initialize a fake master/client and expect to deploy
29 29
 // a router image in docker.  It then sends watch events through the simulator and makes http client requests that
30
-// should go through the deployed router and return data from teh client simulator.
30
+// should go through the deployed router and return data from the client simulator.
31 31
 func TestRouter(t *testing.T) {
32 32
 	//create a server which will act as a user deployed application that
33 33
 	//serves http and https as well as act as a master to simulate watches