... | ... |
@@ -37,8 +37,8 @@ func (s *ClientLookupTokenRetriever) GetToken(namespace, name string) (string, e |
37 | 37 |
// Get the secrets |
38 | 38 |
// TODO: JTL: create one directly once we have that ability |
39 | 39 |
for _, secretRef := range serviceAccount.Secrets { |
40 |
- secret, err := s.Client.Secrets(namespace).Get(secretRef.Name) |
|
41 |
- if err != nil { |
|
40 |
+ secret, err2 := s.Client.Secrets(namespace).Get(secretRef.Name) |
|
41 |
+ if err2 != nil { |
|
42 | 42 |
// Tolerate fetch errors on a particular secret |
43 | 43 |
continue |
44 | 44 |
} |
... | ... |
@@ -244,9 +244,9 @@ func (e *DockercfgController) createTokenSecret(serviceAccount *api.ServiceAccou |
244 | 244 |
// now we have to wait for the service account token controller to make this valid |
245 | 245 |
// TODO remove this once we have a create-token endpoint |
246 | 246 |
for i := 0; i <= tokenSecretWaitTimes; i++ { |
247 |
- liveTokenSecret, err := e.client.Secrets(tokenSecret.Namespace).Get(tokenSecret.Name) |
|
248 |
- if err != nil { |
|
249 |
- return nil, err |
|
247 |
+ liveTokenSecret, err2 := e.client.Secrets(tokenSecret.Namespace).Get(tokenSecret.Name) |
|
248 |
+ if err2 != nil { |
|
249 |
+ return nil, err2 |
|
250 | 250 |
} |
251 | 251 |
|
252 | 252 |
if len(liveTokenSecret.Data[api.ServiceAccountTokenKey]) > 0 { |
... | ... |
@@ -259,8 +259,8 @@ func (e *DockercfgController) createTokenSecret(serviceAccount *api.ServiceAccou |
259 | 259 |
|
260 | 260 |
// the token wasn't ever created, attempt deletion |
261 | 261 |
glog.Warningf("Deleting unfilled token secret %s/%s", tokenSecret.Namespace, tokenSecret.Name) |
262 |
- if err := e.client.Secrets(tokenSecret.Namespace).Delete(tokenSecret.Name); (err != nil) && !kapierrors.IsNotFound(err) { |
|
263 |
- util.HandleError(err) |
|
262 |
+ if deleteErr := e.client.Secrets(tokenSecret.Namespace).Delete(tokenSecret.Name); (deleteErr != nil) && !kapierrors.IsNotFound(deleteErr) { |
|
263 |
+ util.HandleError(deleteErr) |
|
264 | 264 |
} |
265 | 265 |
return nil, fmt.Errorf("token never generated for %s", tokenSecret.Name) |
266 | 266 |
} |
... | ... |
@@ -182,15 +182,15 @@ func (e *DockerRegistryServiceController) handleLocationChange(serviceLocation s |
182 | 182 |
t := credentialprovider.DockerConfig(dockercfgMap) |
183 | 183 |
dockercfg = &t |
184 | 184 |
|
185 |
- dockercfgContent, err := json.Marshal(dockercfg) |
|
186 |
- if err != nil { |
|
187 |
- util.HandleError(err) |
|
185 |
+ dockercfgContent, err2 := json.Marshal(dockercfg) |
|
186 |
+ if err2 != nil { |
|
187 |
+ util.HandleError(err2) |
|
188 | 188 |
continue |
189 | 189 |
} |
190 | 190 |
dockercfgSecret.Data[api.DockerConfigKey] = dockercfgContent |
191 | 191 |
|
192 |
- if _, err := e.client.Secrets(dockercfgSecret.Namespace).Update(dockercfgSecret); err != nil { |
|
193 |
- util.HandleError(err) |
|
192 |
+ if _, updateErr := e.client.Secrets(dockercfgSecret.Namespace).Update(dockercfgSecret); updateErr != nil { |
|
193 |
+ util.HandleError(updateErr) |
|
194 | 194 |
continue |
195 | 195 |
} |
196 | 196 |
} |