Browse code
treat notfound and badrequest instantiate errors as fatal
Ben Parees authored on 2016/07/14 06:18:26Showing 1 changed files
| ... | ... |
@@ -79,7 +79,7 @@ func (c *BuildConfigController) HandleBuildConfig(bc *buildapi.BuildConfig) erro |
| 79 | 79 |
if kerrors.IsConflict(err) {
|
| 80 | 80 |
instantiateErr = fmt.Errorf("unable to instantiate Build for BuildConfig %s/%s due to a conflicting update: %v", bc.Namespace, bc.Name, err)
|
| 81 | 81 |
utilruntime.HandleError(instantiateErr) |
| 82 |
- } else if buildgenerator.IsFatal(err) {
|
|
| 82 |
+ } else if buildgenerator.IsFatal(err) || kerrors.IsNotFound(err) || kerrors.IsBadRequest(err) {
|
|
| 83 | 83 |
return &ConfigControllerFatalError{err.Error()}
|
| 84 | 84 |
} else {
|
| 85 | 85 |
instantiateErr = fmt.Errorf("error instantiating Build from BuildConfig %s/%s: %v", bc.Namespace, bc.Name, err)
|