Browse code

fix a logical error of the function 'RunCmdRouter' in the , the same as the funtion 'RunCmdRegistry' in the

Yanqiang Miao authored on 2016/08/18 19:05:01
Showing 2 changed files
... ...
@@ -257,19 +257,19 @@ func (opts *RegistryOptions) RunCmdRegistry() error {
257 257
 
258 258
 	output := opts.Config.Action.ShouldPrint()
259 259
 	generate := output
260
-	if !generate {
261
-		service, err := opts.serviceClient.Services(opts.namespace).Get(name)
262
-		if err != nil {
263
-			if !errors.IsNotFound(err) && !generate {
260
+	service, err := opts.serviceClient.Services(opts.namespace).Get(name)
261
+	if err != nil {
262
+		if !generate {
263
+			if !errors.IsNotFound(err) {
264 264
 				return fmt.Errorf("can't check for existing docker-registry %q: %v", name, err)
265 265
 			}
266
-			if !output && opts.Config.Action.DryRun {
266
+			if opts.Config.Action.DryRun {
267 267
 				return fmt.Errorf("Docker registry %q service does not exist", name)
268 268
 			}
269 269
 			generate = true
270
-		} else {
271
-			clusterIP = service.Spec.ClusterIP
272 270
 		}
271
+	} else {
272
+		clusterIP = service.Spec.ClusterIP
273 273
 	}
274 274
 
275 275
 	if !generate {
... ...
@@ -539,9 +539,9 @@ func RunCmdRouter(f *clientcmd.Factory, cmd *cobra.Command, out io.Writer, cfg *
539 539
 
540 540
 	output := cfg.Action.ShouldPrint()
541 541
 	generate := output
542
-	if !generate {
543
-		service, err := kClient.Services(namespace).Get(name)
544
-		if err != nil {
542
+	service, err := kClient.Services(namespace).Get(name)
543
+	if err != nil {
544
+		if !generate {
545 545
 			if !errors.IsNotFound(err) {
546 546
 				return fmt.Errorf("can't check for existing router %q: %v", name, err)
547 547
 			}
... ...
@@ -549,10 +549,11 @@ func RunCmdRouter(f *clientcmd.Factory, cmd *cobra.Command, out io.Writer, cfg *
549 549
 				return fmt.Errorf("Router %q service does not exist", name)
550 550
 			}
551 551
 			generate = true
552
-		} else {
553
-			clusterIP = service.Spec.ClusterIP
554 552
 		}
553
+	} else {
554
+		clusterIP = service.Spec.ClusterIP
555 555
 	}
556
+
556 557
 	if !generate {
557 558
 		fmt.Fprintf(out, "Router %q service exists\n", name)
558 559
 		return nil