Browse code

deployments: stop using --follow to verify the env var in test

Michal Fojtik authored on 2016/10/31 19:26:00
Showing 2 changed files
... ...
@@ -290,7 +290,7 @@ var _ = g.Describe("deploymentconfigs", func() {
290 290
 
291 291
 	g.Describe("with env in params referencing the configmap [Conformance]", func() {
292 292
 		g.AfterEach(func() {
293
-			failureTrap(oc, "example", g.CurrentGinkgoTestDescription().Failed)
293
+			failureTrap(oc, "deploymenty-simple", g.CurrentGinkgoTestDescription().Failed)
294 294
 		})
295 295
 		g.It("should expand the config map key to a value", func() {
296 296
 			_, err := oc.Run("create").Args("configmap", "test", "--from-literal=foo=bar").Output()
... ...
@@ -298,8 +298,15 @@ var _ = g.Describe("deploymentconfigs", func() {
298 298
 
299 299
 			_, name, err := createFixture(oc, envRefDeploymentFixture)
300 300
 			o.Expect(err).NotTo(o.HaveOccurred())
301
+			o.Expect(waitForSyncedConfig(oc, name, deploymentRunTimeout)).NotTo(o.HaveOccurred())
301 302
 
302
-			out, err := oc.Run("deploy").Args("dc/"+name, "--latest", "--follow").Output()
303
+			_, err = oc.Run("rollout").Args("latest", "dc/"+name).Output()
304
+			o.Expect(err).NotTo(o.HaveOccurred())
305
+
306
+			out, _ := oc.Run("rollout").Args("status", "dc/"+name).Output()
307
+			o.Expect(out).To(o.ContainSubstring("has failed progressing"))
308
+
309
+			out, err = oc.Run("logs").Args("dc/" + name).Output()
303 310
 			o.Expect(err).NotTo(o.HaveOccurred())
304 311
 			o.Expect(out).To(o.ContainSubstring("hello bar"))
305 312
 		})
... ...
@@ -307,7 +314,7 @@ var _ = g.Describe("deploymentconfigs", func() {
307 307
 
308 308
 	g.Describe("with multiple image change triggers [Conformance]", func() {
309 309
 		g.AfterEach(func() {
310
-			failureTrap(oc, "example", g.CurrentGinkgoTestDescription().Failed)
310
+			failureTrap(oc, "deployment-simple", g.CurrentGinkgoTestDescription().Failed)
311 311
 		})
312 312
 
313 313
 		g.It("should run a successful deployment with multiple triggers", func() {
... ...
@@ -542,7 +549,7 @@ var _ = g.Describe("deploymentconfigs", func() {
542 542
 			o.Expect(out).To(o.ContainSubstring("cannot deploy a paused deployment config"))
543 543
 
544 544
 			g.By("verifying that we cannot start a new deployment via oc rollout")
545
-			out, err := oc.Run("rollout").Args("latest", resource).Output()
545
+			out, err = oc.Run("rollout").Args("latest", resource).Output()
546 546
 			o.Expect(err).To(o.HaveOccurred())
547 547
 			o.Expect(out).To(o.ContainSubstring("cannot deploy a paused deployment config"))
548 548
 
... ...
@@ -20,7 +20,7 @@ spec:
20 20
                 configMapKeyRef:
21 21
                   name: test
22 22
                   key: foo
23
-          command: ["/bin/bash", "-c", "echo hello ${HELLO}"]
23
+          command: ["/bin/bash", "-c", "echo hello ${HELLO} && exit 1"]
24 24
   template:
25 25
     metadata:
26 26
       labels:
... ...
@@ -28,6 +28,6 @@ spec:
28 28
     spec:
29 29
       containers:
30 30
       - image: "openshift/origin-base:latest"
31
-        args: [ "sleep 120" ]
31
+        command: [ "/bin/bash", "-c", "sleep infinity" ]
32 32
         imagePullPolicy: IfNotPresent
33 33
         name: myapp