Browse code

Make hack commands more consistent and add policy to bindata

Add the default policy to bindata

Clayton Coleman authored on 2016/08/10 10:28:08
Showing 9 changed files
... ...
@@ -64,14 +64,14 @@ verify: build
64 64
 	hack/verify-upstream-commits.sh
65 65
 	hack/verify-gofmt.sh
66 66
 	hack/verify-govet.sh
67
+	hack/verify-generated-bootstrap-bindata.sh
67 68
 	hack/verify-generated-deep-copies.sh
68 69
 	hack/verify-generated-conversions.sh
69 70
 	hack/verify-generated-clientsets.sh
70 71
 	hack/verify-generated-completions.sh
71 72
 	hack/verify-generated-docs.sh
72
-	hack/verify-generated-swagger-spec.sh
73
-	hack/verify-bootstrap-bindata.sh
74 73
 	hack/verify-generated-swagger-descriptions.sh
74
+	hack/verify-generated-swagger-spec.sh
75 75
 .PHONY: verify
76 76
 
77 77
 # Update all generated artifacts.
... ...
@@ -79,13 +79,14 @@ verify: build
79 79
 # Example:
80 80
 #   make update
81 81
 update: build
82
-	hack/update-generated-completions.sh
83
-	hack/update-generated-conversions.sh
82
+	hack/update-generated-bootstrap-bindata.sh
84 83
 	hack/update-generated-deep-copies.sh
84
+	hack/update-generated-conversions.sh
85
+	hack/update-generated-clientsets.sh
86
+	hack/update-generated-completions.sh
85 87
 	hack/update-generated-docs.sh
86 88
 	hack/update-generated-swagger-descriptions.sh
87 89
 	hack/update-generated-swagger-spec.sh
88
-	hack/update-generated-clientsets.sh
89 90
 .PHONY: update
90 91
 
91 92
 # Run unit tests.
92 93
deleted file mode 100755
... ...
@@ -1,28 +0,0 @@
1
-#!/bin/bash
2
-
3
-set -o errexit
4
-set -o nounset
5
-set -o pipefail
6
-
7
-STARTTIME=$(date +%s)
8
-OS_ROOT=$(dirname "${BASH_SOURCE}")/..
9
-source "${OS_ROOT}/hack/lib/init.sh"
10
-os::log::stacktrace::install
11
-
12
-EXAMPLES=examples
13
-OUTPUT_PARENT=${OUTPUT_ROOT:-$OS_ROOT}
14
-
15
-pushd vendor/github.com/jteeuwen/go-bindata > /dev/null
16
-  go install ./...
17
-popd > /dev/null
18
-
19
-pushd "${OS_ROOT}" > /dev/null
20
-  "$(os::util::find-go-binary go-bindata)" -nocompress -nometadata -prefix "bootstrap" -pkg "bootstrap" \
21
-                                   -o "${OUTPUT_PARENT}/pkg/bootstrap/bindata.go" -ignore "README.md" \
22
-                                   ${EXAMPLES}/image-streams/... \
23
-                                   ${EXAMPLES}/db-templates/... \
24
-                                   ${EXAMPLES}/jenkins/pipeline/... \
25
-                                   ${EXAMPLES}/quickstarts/...
26
-popd > /dev/null
27
-
28
-ret=$?; ENDTIME=$(date +%s); echo "$0 took $(($ENDTIME - $STARTTIME)) seconds"; exit "$ret"
29 1
deleted file mode 100755
... ...
@@ -1,18 +0,0 @@
1
-#!/bin/bash
2
-
3
-# Script to generate docs from the latest swagger spec.
4
-
5
-set -o errexit
6
-set -o nounset
7
-set -o pipefail
8
-
9
-OS_ROOT=$(dirname "${BASH_SOURCE}")/..
10
-cd "${OS_ROOT}"
11
-source "${OS_ROOT}/hack/lib/init.sh"
12
-os::log::stacktrace::install
13
-
14
-pushd "${OS_ROOT}/hack/swagger-doc" > /dev/null
15
-gradle gendocs --info
16
-popd > /dev/null
17
-
18
-echo "[INFO] Swagger doc generation successful"
19 1
new file mode 100755
... ...
@@ -0,0 +1,31 @@
0
+#!/bin/bash
1
+
2
+set -o errexit
3
+set -o nounset
4
+set -o pipefail
5
+
6
+STARTTIME=$(date +%s)
7
+OS_ROOT=$(dirname "${BASH_SOURCE}")/..
8
+source "${OS_ROOT}/hack/lib/init.sh"
9
+os::log::stacktrace::install
10
+
11
+EXAMPLES=examples
12
+OUTPUT_PARENT=${OUTPUT_ROOT:-$OS_ROOT}
13
+
14
+if [[ -z "$( which go-bindata )" ]]; then
15
+  pushd vendor/github.com/jteeuwen/go-bindata > /dev/null
16
+    go install ./...
17
+  popd > /dev/null
18
+fi
19
+
20
+pushd "${OS_ROOT}" > /dev/null
21
+  "$(os::util::find-go-binary go-bindata)" -nocompress -nometadata -prefix "bootstrap" -pkg "bootstrap" \
22
+                                   -o "${OUTPUT_PARENT}/pkg/bootstrap/bindata.go" -ignore "README.md" -ignore ".*\.go$" \
23
+                                   ${EXAMPLES}/image-streams/... \
24
+                                   ${EXAMPLES}/db-templates/... \
25
+                                   ${EXAMPLES}/jenkins/pipeline/... \
26
+                                   ${EXAMPLES}/quickstarts/... \
27
+                                   pkg/image/admission/imagepolicy/api/v1/...
28
+popd > /dev/null
29
+
30
+ret=$?; ENDTIME=$(date +%s); echo "$0 took $(($ENDTIME - $STARTTIME)) seconds"; exit "$ret"
... ...
@@ -10,7 +10,6 @@ source "${OS_ROOT}/hack/lib/init.sh"
10 10
 # Go to the top of the tree.
11 11
 cd "${OS_ROOT}"
12 12
 
13
-# Do not allow a synthetic GOPATH for these checks
14 13
 os::build::setup_env
15 14
 
16 15
 "${OS_ROOT}/hack/build-go.sh" tools/genconversion
... ...
@@ -10,7 +10,6 @@ source "${OS_ROOT}/hack/lib/init.sh"
10 10
 # Go to the top of the tree.
11 11
 cd "${OS_ROOT}"
12 12
 
13
-# Do not allow a synthetic GOPATH for these checks
14 13
 os::build::setup_env
15 14
 
16 15
 "${OS_ROOT}/hack/build-go.sh" tools/gendeepcopy
17 16
new file mode 100755
... ...
@@ -0,0 +1,18 @@
0
+#!/bin/bash
1
+
2
+# Script to generate docs from the latest swagger spec.
3
+
4
+set -o errexit
5
+set -o nounset
6
+set -o pipefail
7
+
8
+OS_ROOT=$(dirname "${BASH_SOURCE}")/..
9
+cd "${OS_ROOT}"
10
+source "${OS_ROOT}/hack/lib/init.sh"
11
+os::log::stacktrace::install
12
+
13
+pushd "${OS_ROOT}/hack/swagger-doc" > /dev/null
14
+gradle gendocs --info
15
+popd > /dev/null
16
+
17
+echo "[INFO] Swagger doc generation successful"
0 18
deleted file mode 100755
... ...
@@ -1,34 +0,0 @@
1
-#!/bin/bash
2
-
3
-set -o errexit
4
-set -o nounset
5
-set -o pipefail
6
-
7
-OS_ROOT=$(dirname "${BASH_SOURCE}")/..
8
-source "${OS_ROOT}/hack/lib/init.sh"
9
-
10
-cd "${OS_ROOT}"
11
-
12
-echo "===== Verifying Generated Bootstrap Bindata ====="
13
-
14
-TMP_GENERATED_BOOTSTRAP_DIR="_output/verify-bootstrap-bindata"
15
-
16
-echo "Generating bootstrap bindata..."
17
-if ! output=`OUTPUT_ROOT=${TMP_GENERATED_BOOTSTRAP_DIR} ${OS_ROOT}/hack/gen-bootstrap-bindata.sh 2>&1`
18
-then
19
-	echo "FAILURE: Generation of fresh bindata failed:"
20
-	echo "$output"
21
-  exit 1
22
-fi
23
-
24
-echo "Diffing current bootstrap bindata against freshly generated bindata"
25
-ret=0
26
-diff -Naup "${OS_ROOT}/pkg/bootstrap/bindata.go" "${TMP_GENERATED_BOOTSTRAP_DIR}/pkg/bootstrap/bindata.go" || ret=$?
27
-rm -rf "${TMP_GENERATED_BOOTSTRAP_DIR}"
28
-if [[ $ret -eq 0 ]]
29
-then
30
-  echo "SUCCESS: Generated bootstrap bindata up to date."
31
-else
32
-  echo "FAILURE: Generated bootstrap bindata out of date. Please run hack/gen-bootstrap-bindata.sh"
33
-  exit 1
34
-fi
35 1
new file mode 100755
... ...
@@ -0,0 +1,34 @@
0
+#!/bin/bash
1
+
2
+set -o errexit
3
+set -o nounset
4
+set -o pipefail
5
+
6
+OS_ROOT=$(dirname "${BASH_SOURCE}")/..
7
+source "${OS_ROOT}/hack/lib/init.sh"
8
+
9
+cd "${OS_ROOT}"
10
+
11
+echo "===== Verifying Generated Bootstrap Bindata ====="
12
+
13
+TMP_GENERATED_BOOTSTRAP_DIR="_output/verify-bootstrap-bindata"
14
+
15
+echo "Generating bootstrap bindata..."
16
+if ! output=`OUTPUT_ROOT=${TMP_GENERATED_BOOTSTRAP_DIR} ${OS_ROOT}/hack/update-generated-bootstrap-bindata.sh 2>&1`
17
+then
18
+	echo "FAILURE: Generation of fresh bindata failed:"
19
+	echo "$output"
20
+  exit 1
21
+fi
22
+
23
+echo "Diffing current bootstrap bindata against freshly generated bindata"
24
+ret=0
25
+diff -Naup "${OS_ROOT}/pkg/bootstrap/bindata.go" "${TMP_GENERATED_BOOTSTRAP_DIR}/pkg/bootstrap/bindata.go" || ret=$?
26
+rm -rf "${TMP_GENERATED_BOOTSTRAP_DIR}"
27
+if [[ $ret -eq 0 ]]
28
+then
29
+  echo "SUCCESS: Generated bootstrap bindata up to date."
30
+else
31
+  echo "FAILURE: Generated bootstrap bindata out of date. Please run hack/update-generated-bootstrap-bindata.sh"
32
+  exit 1
33
+fi