@@ -4049,6 +4049,7 @@ _oc_secrets_new()

     flags_with_completion=()

     flags_completion=()

+    flags+=("--confirm")

     flags+=("--no-headers")

     flags+=("--output=")

     two_word_flags+=("-o")

@@ -8776,6 +8776,7 @@ _openshift_cli_secrets_new()

     flags_with_completion=()

     flags_completion=()

+    flags+=("--confirm")

     flags+=("--no-headers")

     flags+=("--output=")

     two_word_flags+=("-o")

@@ -62,6 +62,8 @@ type CreateSecretOptions struct {

 	// Controls whether to output warnings

 	Quiet bool

+

+	AllowUnknownTypes bool

 }

 func NewCmdCreateSecret(name, fullName string, f *clientcmd.Factory, out io.Writer) *cobra.Command {

@@ -96,6 +98,7 @@ func NewCmdCreateSecret(name, fullName string, f *clientcmd.Factory, out io.Writ

 	}

 	cmd.Flags().BoolVarP(&options.Quiet, "quiet", "q", options.Quiet, "Suppress warnings")

+	cmd.Flags().BoolVar(&options.AllowUnknownTypes, "confirm", options.AllowUnknownTypes, "Allow unknown secret types.")

 	cmd.Flags().StringVar(&options.SecretTypeName, "type", "", "The type of secret")

 	cmdutil.AddPrinterFlags(cmd)

@@ -143,18 +146,22 @@ func (o *CreateSecretOptions) Validate() error {

 		return errors.New("at least one source file or directory must be specified")

 	}

-nameCheck:

-	switch o.SecretTypeName {

-	case string(kapi.SecretTypeOpaque), "":

-		// this is ok

-	default:

-		// TODO this probably isn't a good idea.  It limits the power of this command.  Maybe allow unknown names with a force?

-		for _, secretType := range KnownSecretTypes {

-			if o.SecretTypeName == string(secretType.Type) {

-				break nameCheck

+	if !o.AllowUnknownTypes {

+		switch o.SecretTypeName {

+		case string(kapi.SecretTypeOpaque), "":

+			// this is ok

+		default:

+			found := false

+			for _, secretType := range KnownSecretTypes {

+				if o.SecretTypeName == string(secretType.Type) {

+					found = true

+					break

+				}

+			}

+			if !found {

+				return fmt.Errorf("unknown secret type %q; use --confirm to use it anyway", o.SecretTypeName)

 			}

 		}

-		return fmt.Errorf("unknown secret type: %v", o.SecretTypeName)

 	}

 	return nil

@@ -10,6 +10,9 @@ source "${OS_ROOT}/hack/cmd_util.sh"

 os::log::install_errexit

 # This test validates secret interaction

+[ "$(oc secrets new foo --type=blah makefile=Makefile 2>&1 | grep 'error: unknown secret type "blah"')" ]

+oc secrets new foo --type=blah makefile=Makefile --confirm

+oc get secrets/foo -o jsonpath={.type} | grep 'blah'

 os::cmd::expect_success 'oc secrets new-dockercfg dockercfg --docker-username=sample-user --docker-password=sample-password --docker-email=fake@example.org'

 # can't use a go template here because the output needs to be base64 decoded.  base64 isn't installed by default in all distros