Browse code

Merge pull request #12240 from smarterclayton/run_all_verify

Merged by openshift-bot

OpenShift Bot authored on 2016/12/20 21:44:24
Showing 2 changed files
... ...
@@ -8,7 +8,7 @@ install:
8 8
   - make install-travis
9 9
 
10 10
 script:
11
-  - PERMISSIVE_GO=y make verify
11
+  - PROTO_OPTIONAL=1 PERMISSIVE_GO=y make verify
12 12
   - make verify-commits
13 13
 
14 14
 notifications:
... ...
@@ -64,21 +64,25 @@ check: | build verify
64 64
 # Example:
65 65
 #   make verify
66 66
 verify: build
67
-	# build-tests is disabled until we can determine why memory usage is so high
68
-	hack/verify-gofmt.sh
69
-	hack/verify-govet.sh
70
-	hack/verify-generated-bootstrap-bindata.sh
71
-	hack/verify-generated-deep-copies.sh
72
-	hack/verify-generated-conversions.sh
73
-	hack/verify-generated-clientsets.sh
74
-	hack/verify-generated-completions.sh
75
-	hack/verify-generated-docs.sh
76
-	hack/verify-cli-conventions.sh
77
-	PROTO_OPTIONAL=1 hack/verify-generated-protobuf.sh
78
-	hack/verify-generated-swagger-descriptions.sh
79
-	hack/verify-generated-swagger-spec.sh
67
+	# build-tests task has been disabled until we can determine why memory usage is so high
68
+	{ \
69
+	hack/verify-gofmt.sh ||r=1;\
70
+	hack/verify-govet.sh ||r=1;\
71
+	hack/verify-generated-bootstrap-bindata.sh ||r=1;\
72
+	hack/verify-generated-deep-copies.sh ||r=1;\
73
+	hack/verify-generated-conversions.sh ||r=1;\
74
+	hack/verify-generated-clientsets.sh ||r=1;\
75
+	hack/verify-generated-completions.sh ||r=1;\
76
+	hack/verify-generated-docs.sh ||r=1;\
77
+	hack/verify-cli-conventions.sh ||r=1;\
78
+	hack/verify-generated-protobuf.sh ||r=1;\
79
+	hack/verify-generated-swagger-descriptions.sh ||r=1;\
80
+	hack/verify-generated-swagger-spec.sh ||r=1;\
81
+	exit $$r ;\
82
+	}
80 83
 .PHONY: verify
81 84
 
85
+
82 86
 # Verify commit comments.
83 87
 #
84 88
 # Example:
... ...
@@ -98,11 +102,18 @@ update: build
98 98
 	hack/update-generated-clientsets.sh
99 99
 	hack/update-generated-completions.sh
100 100
 	hack/update-generated-docs.sh
101
-	PROTO_OPTIONAL=1 hack/update-generated-protobuf.sh
101
+	hack/update-generated-protobuf.sh
102 102
 	hack/update-generated-swagger-descriptions.sh
103 103
 	hack/update-generated-swagger-spec.sh
104 104
 .PHONY: update
105 105
 
106
+# Build and run the complete test-suite.
107
+#
108
+# Example:
109
+#   make test
110
+test: test-tools test-integration test-assets test-end-to-end
111
+.PHONY: test
112
+
106 113
 # Run unit tests.
107 114
 #
108 115
 # Args:
... ...
@@ -141,7 +152,6 @@ test-cmd: build
141 141
 # Example:
142 142
 #   make test-end-to-end
143 143
 test-end-to-end: build
144
-	hack/env hack/verify-generated-protobuf.sh # Test the protobuf serializations when we know Docker is available
145 144
 	hack/test-end-to-end.sh
146 145
 .PHONY: test-end-to-end
147 146
 
... ...
@@ -179,15 +189,6 @@ test-extended:
179 179
 	test/extended/$(SUITE).sh --ginkgo.focus="$(FOCUS)"
180 180
 .PHONY: test-extended
181 181
 
182
-# Build and run the complete test-suite.
183
-#
184
-# Example:
185
-#   make test
186
-test: check
187
-	$(MAKE) test-tools test-integration test-assets -o build
188
-	$(MAKE) test-end-to-end -o build
189
-.PHONY: test
190
-
191 182
 # Run All-in-one OpenShift server.
192 183
 #
193 184
 # Example:
... ...
@@ -225,27 +226,6 @@ release-binaries: clean
225 225
 	hack/extract-release.sh
226 226
 .PHONY: release-binaries
227 227
 
228
-# Release the integrated components for OpenShift, origin, logging, and metrics.
229
-# The current tag in the Origin release (the tag that points to HEAD) is used to
230
-# clone and build each component. Components must have a hack/release.sh script
231
-# which must accept env var OS_TAG as the tag to build. Each component should push
232
-# its own images. See hack/release.sh and hack/push-release.sh for an example of
233
-# the appropriate behavior.
234
-#
235
-# Prerequisites:
236
-# * you must be logged into the remote registry with the appropriate
237
-#   credentials to push.
238
-# * all repositories must have a Git tag equal to the current repositories tag of
239
-#   HEAD
240
-#
241
-# TODO: consider making hack/release.sh be a make target (make official-release).
242
-#
243
-# Example:
244
-#   make release-components
245
-release-components: clean
246
-	hack/release-components.sh
247
-.PHONY: release-components
248
-
249 228
 # Build the cross compiled release binaries
250 229
 #
251 230
 # Example: