package rolling import ( "bytes" "fmt" "testing" "time" kapi "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/apimachinery/registered" "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/fake" "k8s.io/kubernetes/pkg/client/testing/core" "k8s.io/kubernetes/pkg/kubectl" "k8s.io/kubernetes/pkg/runtime" deployapi "github.com/openshift/origin/pkg/deploy/api" deploytest "github.com/openshift/origin/pkg/deploy/api/test" strat "github.com/openshift/origin/pkg/deploy/strategy" deployutil "github.com/openshift/origin/pkg/deploy/util" _ "github.com/openshift/origin/pkg/api/install" ) func TestRolling_deployInitial(t *testing.T) { initialStrategyInvoked := false strategy := &RollingDeploymentStrategy{ decoder: kapi.Codecs.UniversalDecoder(), rcClient: fake.NewSimpleClientset().Core(), eventClient: fake.NewSimpleClientset().Core(), initialStrategy: &testStrategy{ deployFn: func(from *kapi.ReplicationController, to *kapi.ReplicationController, desiredReplicas int, updateAcceptor strat.UpdateAcceptor) error { initialStrategyInvoked = true return nil }, }, rollingUpdate: func(config *kubectl.RollingUpdaterConfig) error { t.Fatalf("unexpected call to rollingUpdate") return nil }, getUpdateAcceptor: getUpdateAcceptor, apiRetryPeriod: 1 * time.Millisecond, apiRetryTimeout: 10 * time.Millisecond, } config := deploytest.OkDeploymentConfig(1) config.Spec.Strategy = deploytest.OkRollingStrategy() deployment, _ := deployutil.MakeDeployment(config, kapi.Codecs.LegacyCodec(registered.GroupOrDie(kapi.GroupName).GroupVersions[0])) strategy.out, strategy.errOut = &bytes.Buffer{}, &bytes.Buffer{} err := strategy.Deploy(nil, deployment, 2) if err != nil { t.Fatalf("unexpected error: %v", err) } if !initialStrategyInvoked { t.Fatalf("expected initial strategy to be invoked") } } func TestRolling_deployRolling(t *testing.T) { latestConfig := deploytest.OkDeploymentConfig(1) latestConfig.Spec.Strategy = deploytest.OkRollingStrategy() latest, _ := deployutil.MakeDeployment(latestConfig, kapi.Codecs.LegacyCodec(registered.GroupOrDie(kapi.GroupName).GroupVersions[0])) config := deploytest.OkDeploymentConfig(2) config.Spec.Strategy = deploytest.OkRollingStrategy() deployment, _ := deployutil.MakeDeployment(config, kapi.Codecs.LegacyCodec(registered.GroupOrDie(kapi.GroupName).GroupVersions[0])) deployments := map[string]*kapi.ReplicationController{ latest.Name: latest, deployment.Name: deployment, } deploymentUpdated := false client := &fake.Clientset{} client.AddReactor("get", "replicationcontrollers", func(action core.Action) (handled bool, ret runtime.Object, err error) { name := action.(core.GetAction).GetName() return true, deployments[name], nil }) client.AddReactor("update", "replicationcontrollers", func(action core.Action) (handled bool, ret runtime.Object, err error) { updated := action.(core.UpdateAction).GetObject().(*kapi.ReplicationController) deploymentUpdated = true return true, updated, nil }) var rollingConfig *kubectl.RollingUpdaterConfig strategy := &RollingDeploymentStrategy{ decoder: kapi.Codecs.UniversalDecoder(), rcClient: client.Core(), eventClient: fake.NewSimpleClientset().Core(), initialStrategy: &testStrategy{ deployFn: func(from *kapi.ReplicationController, to *kapi.ReplicationController, desiredReplicas int, updateAcceptor strat.UpdateAcceptor) error { t.Fatalf("unexpected call to initial strategy") return nil }, }, rollingUpdate: func(config *kubectl.RollingUpdaterConfig) error { rollingConfig = config return nil }, getUpdateAcceptor: getUpdateAcceptor, apiRetryPeriod: 1 * time.Millisecond, apiRetryTimeout: 10 * time.Millisecond, } strategy.out, strategy.errOut = &bytes.Buffer{}, &bytes.Buffer{} err := strategy.Deploy(latest, deployment, 2) if err != nil { t.Fatalf("unexpected error: %v", err) } if rollingConfig == nil { t.Fatalf("expected rolling update to be invoked") } if e, a := latest, rollingConfig.OldRc; e != a { t.Errorf("expected rollingConfig.OldRc %v, got %v", e, a) } if e, a := deployment, rollingConfig.NewRc; e != a { t.Errorf("expected rollingConfig.NewRc %v, got %v", e, a) } if e, a := 1*time.Second, rollingConfig.Interval; e != a { t.Errorf("expected Interval %d, got %d", e, a) } if e, a := 1*time.Second, rollingConfig.UpdatePeriod; e != a { t.Errorf("expected UpdatePeriod %d, got %d", e, a) } if e, a := 20*time.Second, rollingConfig.Timeout; e != a { t.Errorf("expected Timeout %d, got %d", e, a) } // verify hack if e, a := int32(1), rollingConfig.NewRc.Spec.Replicas; e != a { t.Errorf("expected rollingConfig.NewRc.Spec.Replicas %d, got %d", e, a) } // verify hack if !deploymentUpdated { t.Errorf("expected deployment to be updated for source annotation") } sid := fmt.Sprintf("%s:%s", latest.Name, latest.ObjectMeta.UID) if e, a := sid, rollingConfig.NewRc.Annotations[sourceIdAnnotation]; e != a { t.Errorf("expected sourceIdAnnotation %s, got %s", e, a) } } type hookExecutorImpl struct { executeFunc func(hook *deployapi.LifecycleHook, deployment *kapi.ReplicationController, suffix, label string) error } func (h *hookExecutorImpl) Execute(hook *deployapi.LifecycleHook, rc *kapi.ReplicationController, suffix, label string) error { return h.executeFunc(hook, rc, suffix, label) } func TestRolling_deployRollingHooks(t *testing.T) { config := deploytest.OkDeploymentConfig(1) config.Spec.Strategy = deploytest.OkRollingStrategy() latest, _ := deployutil.MakeDeployment(config, kapi.Codecs.LegacyCodec(registered.GroupOrDie(kapi.GroupName).GroupVersions[0])) var hookError error deployments := map[string]*kapi.ReplicationController{latest.Name: latest} client := &fake.Clientset{} client.AddReactor("get", "replicationcontrollers", func(action core.Action) (handled bool, ret runtime.Object, err error) { name := action.(core.GetAction).GetName() return true, deployments[name], nil }) client.AddReactor("update", "replicationcontrollers", func(action core.Action) (handled bool, ret runtime.Object, err error) { updated := action.(core.UpdateAction).GetObject().(*kapi.ReplicationController) return true, updated, nil }) strategy := &RollingDeploymentStrategy{ decoder: kapi.Codecs.UniversalDecoder(), rcClient: client.Core(), eventClient: fake.NewSimpleClientset().Core(), initialStrategy: &testStrategy{ deployFn: func(from *kapi.ReplicationController, to *kapi.ReplicationController, desiredReplicas int, updateAcceptor strat.UpdateAcceptor) error { t.Fatalf("unexpected call to initial strategy") return nil }, }, rollingUpdate: func(config *kubectl.RollingUpdaterConfig) error { return nil }, hookExecutor: &hookExecutorImpl{ executeFunc: func(hook *deployapi.LifecycleHook, deployment *kapi.ReplicationController, suffix, label string) error { return hookError }, }, getUpdateAcceptor: getUpdateAcceptor, apiRetryPeriod: 1 * time.Millisecond, apiRetryTimeout: 10 * time.Millisecond, } cases := []struct { params *deployapi.RollingDeploymentStrategyParams hookShouldFail bool deploymentShouldFail bool }{ {rollingParams(deployapi.LifecycleHookFailurePolicyAbort, ""), true, true}, {rollingParams(deployapi.LifecycleHookFailurePolicyAbort, ""), false, false}, {rollingParams("", deployapi.LifecycleHookFailurePolicyAbort), true, true}, {rollingParams("", deployapi.LifecycleHookFailurePolicyAbort), false, false}, } for _, tc := range cases { config := deploytest.OkDeploymentConfig(2) config.Spec.Strategy.RollingParams = tc.params deployment, _ := deployutil.MakeDeployment(config, kapi.Codecs.LegacyCodec(registered.GroupOrDie(kapi.GroupName).GroupVersions[0])) deployments[deployment.Name] = deployment hookError = nil if tc.hookShouldFail { hookError = fmt.Errorf("hook failure") } strategy.out, strategy.errOut = &bytes.Buffer{}, &bytes.Buffer{} err := strategy.Deploy(latest, deployment, 2) if err != nil && tc.deploymentShouldFail { t.Logf("got expected error: %v", err) } if err == nil && tc.deploymentShouldFail { t.Errorf("expected an error for case: %#v", tc) } if err != nil && !tc.deploymentShouldFail { t.Errorf("unexpected error for case: %#v: %v", tc, err) } } } // TestRolling_deployInitialHooks can go away once the rolling strategy // supports initial deployments. func TestRolling_deployInitialHooks(t *testing.T) { var hookError error strategy := &RollingDeploymentStrategy{ decoder: kapi.Codecs.UniversalDecoder(), rcClient: fake.NewSimpleClientset().Core(), eventClient: fake.NewSimpleClientset().Core(), initialStrategy: &testStrategy{ deployFn: func(from *kapi.ReplicationController, to *kapi.ReplicationController, desiredReplicas int, updateAcceptor strat.UpdateAcceptor) error { return nil }, }, rollingUpdate: func(config *kubectl.RollingUpdaterConfig) error { return nil }, hookExecutor: &hookExecutorImpl{ executeFunc: func(hook *deployapi.LifecycleHook, deployment *kapi.ReplicationController, suffix, label string) error { return hookError }, }, getUpdateAcceptor: getUpdateAcceptor, apiRetryPeriod: 1 * time.Millisecond, apiRetryTimeout: 10 * time.Millisecond, } cases := []struct { params *deployapi.RollingDeploymentStrategyParams hookShouldFail bool deploymentShouldFail bool }{ {rollingParams(deployapi.LifecycleHookFailurePolicyAbort, ""), true, true}, {rollingParams(deployapi.LifecycleHookFailurePolicyAbort, ""), false, false}, {rollingParams("", deployapi.LifecycleHookFailurePolicyAbort), true, true}, {rollingParams("", deployapi.LifecycleHookFailurePolicyAbort), false, false}, } for i, tc := range cases { config := deploytest.OkDeploymentConfig(2) config.Spec.Strategy.RollingParams = tc.params deployment, _ := deployutil.MakeDeployment(config, kapi.Codecs.LegacyCodec(registered.GroupOrDie(kapi.GroupName).GroupVersions[0])) hookError = nil if tc.hookShouldFail { hookError = fmt.Errorf("hook failure") } strategy.out, strategy.errOut = &bytes.Buffer{}, &bytes.Buffer{} err := strategy.Deploy(nil, deployment, 2) if err != nil && tc.deploymentShouldFail { t.Logf("got expected error: %v", err) } if err == nil && tc.deploymentShouldFail { t.Errorf("%d: expected an error for case: %v", i, tc) } if err != nil && !tc.deploymentShouldFail { t.Errorf("%d: unexpected error for case: %v: %v", i, tc, err) } } } type testStrategy struct { deployFn func(from *kapi.ReplicationController, to *kapi.ReplicationController, desiredReplicas int, updateAcceptor strat.UpdateAcceptor) error } func (s *testStrategy) DeployWithAcceptor(from *kapi.ReplicationController, to *kapi.ReplicationController, desiredReplicas int, updateAcceptor strat.UpdateAcceptor) error { return s.deployFn(from, to, desiredReplicas, updateAcceptor) } func mkintp(i int) *int64 { v := int64(i) return &v } func rollingParams(preFailurePolicy, postFailurePolicy deployapi.LifecycleHookFailurePolicy) *deployapi.RollingDeploymentStrategyParams { var pre *deployapi.LifecycleHook var post *deployapi.LifecycleHook if len(preFailurePolicy) > 0 { pre = &deployapi.LifecycleHook{ FailurePolicy: preFailurePolicy, ExecNewPod: &deployapi.ExecNewPodHook{}, } } if len(postFailurePolicy) > 0 { post = &deployapi.LifecycleHook{ FailurePolicy: postFailurePolicy, ExecNewPod: &deployapi.ExecNewPodHook{}, } } return &deployapi.RollingDeploymentStrategyParams{ UpdatePeriodSeconds: mkintp(1), IntervalSeconds: mkintp(1), TimeoutSeconds: mkintp(20), Pre: pre, Post: post, } } func getUpdateAcceptor(timeout time.Duration, minReadySeconds int32) strat.UpdateAcceptor { return &testAcceptor{ acceptFn: func(deployment *kapi.ReplicationController) error { return nil }, } } type testAcceptor struct { acceptFn func(*kapi.ReplicationController) error } func (t *testAcceptor) Accept(deployment *kapi.ReplicationController) error { return t.acceptFn(deployment) }