Browse code

SpecDeps.py : Convert from optparse to argparse module

Change-Id: Ic8afe9d3484100aea13670ad4be2c0f9a21a3618
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/4605
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Reviewed-by: Divya Thaluru <dthaluru@vmware.com>

xiaolin-vmware authored on 2018/01/06 08:06:59
Showing 1 changed files
... ...
@@ -5,9 +5,7 @@
5 5
 #    Author: Harish Udaiya Kumar <hudaiyakumar@vmware.com>
6 6
 import sys
7 7
 import os
8
-from optparse import OptionParser
9
-from SpecUtils import Specutils
10
-from SpecData import SerializableSpecObject
8
+from argparse import ArgumentParser
11 9
 from SpecData import SerializedSpecObjects
12 10
 from jsonwrapper import JsonWrapper
13 11
 
... ...
@@ -17,19 +15,17 @@ SPEC_FILE_DIR = "../../SPECS"
17 17
 LOG_FILE_DIR = "../../stage/LOGS"
18 18
 
19 19
 def main():
20
-    usage = (os.path.basename(__file__) +
21
-             "--input-type=[json/pkg/who-needs/who-needs-build] " +
22
-             "--pkg=[pkg_name] --file=<JSON_FILE_NAME> --disp=[tree/list/json]")
23
-    parser = OptionParser(usage)
24
-    parser.add_option("-i", "--input-type", dest="input_type", default=DEFAULT_INPUT_TYPE)
25
-    parser.add_option("-p", "--pkg", dest="pkg")
26
-    parser.add_option("-f", "--file", dest="json_file", default="packages_minimal.json")
27
-    parser.add_option("-d", "--disp", dest="display_option", default=DEFAULT_DISPLAY_OPTION)
28
-    parser.add_option("-s", "--spec-dir", dest="spec_dir", default=SPEC_FILE_DIR)
29
-    parser.add_option("-t", "--stage-dir", dest="stage_dir", default="../../stage")
30
-    parser.add_option("-a", "--input-data-dir", dest="input_data_dir",
31
-                      default="../../common/data/")
32
-    (options,  args) = parser.parse_args()
20
+    usage = "Usage: %prog [options]"
21
+    parser = ArgumentParser(usage)
22
+    parser.add_argument("-i", "--input-type", dest="input_type", default=DEFAULT_INPUT_TYPE)
23
+    parser.add_argument("-p", "--pkg", dest="pkg")
24
+    parser.add_argument("-f", "--file", dest="json_file", default="packages_minimal.json")
25
+    parser.add_argument("-d", "--disp", dest="display_option", default=DEFAULT_DISPLAY_OPTION)
26
+    parser.add_argument("-s", "--spec-dir", dest="spec_dir", default=SPEC_FILE_DIR)
27
+    parser.add_argument("-t", "--stage-dir", dest="stage_dir", default="../../stage")
28
+    parser.add_argument("-a", "--input-data-dir", dest="input_data_dir",
29
+                        default="../../common/data/")
30
+    options = parser.parse_args()
33 31
 
34 32
     if not options.input_data_dir.endswith('/'):
35 33
         options.input_data_dir += '/'
... ...
@@ -42,13 +38,13 @@ def main():
42 42
 
43 43
         # To display/print package dependencies on console
44 44
         if(options.input_type == "pkg" or
45
-            options.input_type == "who-needs" or
46
-            options.input_type == "who-needs-build"):
45
+           options.input_type == "who-needs" or
46
+           options.input_type == "who-needs-build"):
47 47
             targetName = options.pkg
48 48
             specDeps.readSpecsAndConvertToSerializableObjects(options.spec_dir,
49 49
                                                               options.input_type,
50 50
                                                               targetName, displayOption)
51
-        elif(options.input_type == "json"):
51
+        elif options.input_type == "json":
52 52
         # Generate the expanded package dependencies json file based on package_list_file
53 53
             json_wrapper_option_list = JsonWrapper(options.json_file)
54 54
             option_list_json = json_wrapper_option_list.read()
... ...
@@ -60,7 +56,7 @@ def main():
60 60
                     options.spec_dir,
61 61
                     options.input_type, install_option[1]["file"],
62 62
                     displayOption)
63
-    except Exception as error:
63
+    except Exception as _:
64 64
         sys.stderr.write("Failed to generate dependency lists from spec files\n")
65 65
         sys.exit(1)
66 66