k8s-dashboard: Fix build break by using a specific version of closure-library
kubernetes-dashboard is failing to build as shown below:
[10:06:10] gulp-google-closure-compiler: base.js:1950:
WARNING - Parse error. unknown @suppress parameter: strictMissingProperties
* @suppress {strictMissingProperties} superClass_ and base is not defined on
^
base.js:2040: ERROR - unknown type: symbol
if (typeof opt_methodName != 'string' && typeof opt_methodName != 'symbol') {
^^^^^^^^
1 error(s), 1 warning(s), 94.7% typed
[10:06:10] 'scripts:prod' errored after 26 s
[10:06:10] Error in plugin 'gulp-google-closure-compiler'
Message:
Compilation error
The build script pulls down google-closure-library from github as a
dependency. However, since no particular version is specified, it gets
the latest commit (HEAD), which doesn't pass the build at the moment.
Fix this by pulling down a specific version that is known to work.
Change-Id: I72648ba42277448b2c6b6e374a9e5d08623b4327
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/4967
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Reviewed-by: michellew <michellew@vmware.com>
Srivatsa S. Bhat authored on 2018/04/04 04:48:25Showing 1 changed files
| ... | ... |
@@ -1,7 +1,7 @@ |
| 1 | 1 |
Summary: Kubernetes Dashboard UI |
| 2 | 2 |
Name: kubernetes-dashboard |
| 3 | 3 |
Version: 1.6.3 |
| 4 |
-Release: 1%{?dist}
|
|
| 4 |
+Release: 2%{?dist}
|
|
| 5 | 5 |
License: Apache-2.0 |
| 6 | 6 |
URL: https://github.com/kubernetes/dashboard |
| 7 | 7 |
Source0: %{name}-v%{version}.tar.gz
|
| ... | ... |
@@ -30,6 +30,7 @@ Kubernetes Dashboard UI. |
| 30 | 30 |
|
| 31 | 31 |
%build |
| 32 | 32 |
export PATH=${PATH}:/usr/bin
|
| 33 |
+sed -i 's/"google-closure-library": "\*"/"google-closure-library": "v20170521"/' ./bower.json |
|
| 33 | 34 |
npm install |
| 34 | 35 |
npm install babel-loader@7.1.1 |
| 35 | 36 |
./build/postinstall.sh |
| ... | ... |
@@ -51,6 +52,8 @@ cp -p -r ./src/deploy/Dockerfile %{buildroot}/opt/k8dashboard/
|
| 51 | 51 |
/opt/k8dashboard/public/* |
| 52 | 52 |
|
| 53 | 53 |
%changelog |
| 54 |
+* Tue Apr 03 2018 Srivatsa S. Bhat <srivatsa@csail.mit.edu> 1.6.3-2 |
|
| 55 |
+- Fix build break in google-closure-library. |
|
| 54 | 56 |
* Mon Sep 11 2017 Vinay Kulkarni <kulkarniv@vmware.com> 1.6.3-1 |
| 55 | 57 |
- kubernetes-dashboard 1.6.3. |
| 56 | 58 |
* Fri Jul 14 2017 Vinay Kulkarni <kulkarniv@vmware.com> 1.6.1-1 |