@@ -121,7 +121,6 @@ class PackageBuildDataGenerator(object):

         self.__sortedPackageList=sortedList

     def __constructBuildAndRunTimeDependencyGraph(self,package):

-        

         basePackage=constants.specData.getSpecName(package)

         addBuildTimeGraph=True

@@ -153,9 +152,9 @@ class PackageBuildDataGenerator(object):

             self.__constructBuildAndRunTimeDependencyGraph(pkg)

     def __readDependencyGraphAndCyclesForGivenPackages(self,listPackages):

+        self.logger.info("Reading dependency graph to check for cycles")

         for pkg in listPackages:

             self.__constructBuildAndRunTimeDependencyGraph(pkg)

-        

         packagesToBUild=self.__buildDependencyGraph.keys()

         for pkg in packagesToBUild:

             sortedPackageList,circularDependentPackages = self.topologicalSortPackages(self.__buildDependencyGraph,pkg)

@@ -246,6 +245,7 @@ class PackageBuildDataGenerator(object):

     def __findCircularDependencies(self,cyclicDependencyGraph):

+        self.logger.info("Looking for circular dependencies")

         if len(cyclicDependencyGraph) == 0:

             return

         #step1: construct dependency map from dependency graph

@@ -8,6 +8,7 @@ from constants import constants

 from PackageManager import PackageManager 

 import json

+

 def main():

     usage = "Usage: %prog [options] <package name>"

     parser = OptionParser(usage)

@@ -25,6 +26,7 @@ def main():

     logger=Logger.getLogger(options.logPath+"/Main")

     errorFlag=False

+    package = None

     if not os.path.isdir(options.sourcePath):

         logger.error("Given Sources Path is not a directory:"+options.sourcePath)

         errorFlag = True

@@ -49,7 +51,7 @@ def main():

         logger.error("Please provide package name")

         errorFlag = True

-    package=args[0]

+        package=args[0]

     if errorFlag:

         logger.error("Found some errors. Please fix input options and re-run it.")

@@ -112,12 +114,18 @@ def buildAPackage(package):

     pkgManager.buildPackages(listPackages)

 def buildPackagesFromGivenJSONFile(inputJSONFile,buildOption,logger):

-    jsonObj = json.load(inputJSONFile)

+    jsonData=open(inputJSONFile)

+    jsonObj = json.load(jsonData)

+    jsonData.close()

     listPackages=jsonObj[buildOption]

+    listPackagesToBuild=[]

+    for pkg in listPackages:

+        p =  pkg.encode('utf-8')

+        listPackagesToBuild.append(str(p))

     logger.info("List of packages to build:")

-    logger.info(listPackages)

+    logger.info(listPackagesToBuild)

     pkgManager = PackageManager()

-    pkgManager.buildPackages(listPackages)

+    pkgManager.buildPackages(listPackagesToBuild)

 if __name__=="__main__":

@@ -4,12 +4,9 @@ class constants(object):

     specPath=""

     sourcePath=""

     rpmPath=""

-    toolsPath=""

     logPath=""

-    incrementalBuild=False

     topDirPath=""

     specData=None

-    testPath="test"

     buildRootPath="/mnt"

     prevPublishRPMRepo=""

     noDepsPackageList=["texinfo","bzip2","gettext","man-db","nspr","xz","bison"]

@@ -53,10 +50,9 @@ class constants(object):

         constants.specPath = options.specPath

         constants.sourcePath = options.sourcePath

         constants.rpmPath = options.rpmPath

-        constants.toolsPath = options.toolsPath

-        constants.incrementalBuild = options.incrementalBuild

         constants.topDirPath = options.topDirPath

         constants.logPath = options.logPath

+        constants.prevPublishRPMRepo=options.publishRPMSPath

         constants.specData = SerializableSpecObjectsUtils(constants.logPath)

         constants.specData.readSpecsAndConvertToSerializableObjects(constants.specPath)

@@ -58,7 +58,7 @@

                 "automake", "libpcap", "tcpdump", "elfutils-libelf-devel", "elfutils", "elfutils-devel", "elfutils-devel-static", 

 		"elfutils-libelf-devel-static", 

                 "go", "grub-lang", "diffutils", "groff", "man-db", "mpfr-devel", "man-pages", 

-                "hawkey-devel", "python-hawkey", "busybox", "libxml2-devel", "ruby", "readline-devel", "wget", "cifs-utils", 

+                "hawkey-devel", "python-hawkey", "libxml2-devel", "ruby", "readline-devel", "wget", 

                 "Linux-PAM-lang", "make", "bindutils", "gperf", "lua-devel", "which", "less",  

                 "cmake", "gpgme-devel", "parted", "vim", "xz-devel", "xerces-c-devel", "xml-security-c-devel", 

                 "nss-devel", "ncurses-devel", "tzdata", "itstool", "sed-lang", "gptfdisk", "ntp", "flex", "patch", "m4", "dracut", "dracut-tools",