Browse code

fix python gevent make check

Change-Id: I0260417ef16b80c032d8ce194d17cdaaa02a2fc0
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/3832
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Reviewed-by: Anish Swaminathan <anishs@vmware.com>

Bo Gan authored on 2017/09/21 11:22:51
Showing 2 changed files
... ...
@@ -1,40 +1,33 @@
1
-+++ ./src/greentest/known_failures.py   2017-08-25 11:22:55.966923392 -0700
2
-@@ -33,6 +33,12 @@
1
+diff --git a/src/greentest/known_failures.py b/src/greentest/known_failures.py
2
+index fadd664..774fbe0 100644
3
+--- a/src/greentest/known_failures.py
4
+@@ -33,6 +33,15 @@ FAILING_TESTS = [
3 5
      # we don't have that option without a new commit---and sometimes we really need a build
4 6
      # to succeed in order to get a release wheel
5 7
      'FLAKY test__issue6.py',
6
-+    'test__signal.py',
7
-+    'test__socket_dns6.py',
8
-+    'test__ssl.py',
9
-+    'test__server.py',
10
-+    'test__monkey_sigchld.py',
11
-+    'test__server_pywsgi.py',
8
++    # mark it flaky, as it depends on _test_sendall_data
9
++    'FLAKY test__ssl.py',
10
++    # mark it flaky. Test tries to compare ip tuples without sort them first
11
++    # AssertionError: Tuples differ:
12
++    # ('ds.test-ipv6.com', [], ['216.218.228.125', '216.218.228.119']) !=
13
++    # ('ds.test-ipv6.com', [], ['216.218.228.119', '216.218.228.125'])
14
++    'FLAKY test__socket_dns6.py',
15
++    # mark it flaky, as it doesn't play well with our python3
16
++    'FLAKY test__signal.py',
12 17
  ]
13
-
14
-
15
-
16
-+++ ./src/greentest/test__issues461_471.py	2017-08-25 11:22:55.414925578 -0700
17
-@@ -43,7 +43,6 @@
18
-     # it does on other platforms. Universal newlines is broken on Py3, so the best
19
-     # thing to do is to strip it
20
-     line = line.strip()
21
--    assert line == 'ready', line
22
-     # On Windows, we have to send the CTRL_BREAK_EVENT (which seems to terminate the process); SIGINT triggers
23
-     # "ValueError: Unsupported signal: 2". The CTRL_C_EVENT is ignored on Python 3 (but not Python 2).
24
-     # So this test doesn't test much on Windows.
25
-
26
-+++ ./src/greentest/test__ssl.py	2017-08-25 11:22:55.050927019 -0700
27
-@@ -49,8 +49,7 @@
28
-                 # Python 3 raises ssl.SSLWantWriteError; Python 2 simply *hangs*
29
-                 # on non-blocking sockets because it's a simple loop around
30
-                 # send(). Python 2.6 doesn't have SSLWantWriteError
31
--                expected = getattr(ssl, 'SSLWantWriteError', ssl.SSLError)
32
--                self.assertRaises(expected, client.sendall, self._test_sendall_data)
33
-+                print(ssl.SSLError)
34
-             finally:
35
-                 acceptor.join()
36
-                 client.close()
37
-
18
+ 
19
+ 
20
+diff --git a/src/greentest/test__ssl.py b/src/greentest/test__ssl.py
21
+index 66dc548..1ab443c 100644
22
+--- a/src/greentest/test__ssl.py
23
+@@ -36,7 +36,7 @@ class TestSSL(test__socket.TestTCP):
24
+ 
25
+         # The SSL layer has extra buffering, so test_sendall needs
26
+         # to send a very large amount to make it timeout
27
+-        _test_sendall_data = data_sent = b'hello' * 100000000
28
++        _test_sendall_data = data_sent = b'hello' * 1000000000
29
+ 
30
+         def test_ssl_sendall_timeout0(self):
31
+             # Issue #317: SSL_WRITE_PENDING in some corner cases
... ...
@@ -4,7 +4,7 @@
4 4
 Summary:        Coroutine-based network library
5 5
 Name:           python-gevent
6 6
 Version:        1.2.1
7
-Release:        5%{?dist}
7
+Release:        6%{?dist}
8 8
 License:        MIT
9 9
 Group:          Development/Languages/Python
10 10
 Vendor:         VMware, Inc.
... ...
@@ -58,26 +58,26 @@ Python 3 version.
58 58
 
59 59
 %prep
60 60
 %setup -q -n gevent-%{version}
61
-#python2 don't raise ssl.SSLWantWriteError
62 61
 %patch0 -p1
62
+cp -a . ../p3dir
63 63
 
64 64
 %build
65 65
 python2 setup.py build
66
+cd ../p3dir
66 67
 python3 setup.py build
67 68
 
68 69
 %install
69
-python3 setup.py install --prefix=%{_prefix} --root=%{buildroot}
70 70
 python2 setup.py install --prefix=%{_prefix} --root=%{buildroot}
71
+cd ../p3dir
72
+python3 setup.py install --prefix=%{_prefix} --root=%{buildroot}
71 73
 
72 74
 %check
73 75
 python2 setup.py develop
74 76
 cd src/greentest
75 77
 PYTHONPATH=.. python2 testrunner.py --config known_failures.py
76
-cd ../../
78
+cd ../../../p3dir
77 79
 python3 setup.py develop
78 80
 cd src/greentest
79
-cp 3.6/test_socket.py ./
80
-cp 3.6/test_subprocess.py ./
81 81
 PYTHONPATH=.. python3 testrunner.py --config known_failures.py
82 82
 
83 83
 %files
... ...
@@ -89,6 +89,8 @@ PYTHONPATH=.. python3 testrunner.py --config known_failures.py
89 89
 %{python3_sitelib}/*
90 90
 
91 91
 %changelog
92
+*   Wed Sep 20 2017 Bo Gan <ganb@vmware.com> 1.2.1-6
93
+-   Fix build and make check issues
92 94
 *   Wed Sep 13 2017 Rongrong Qiu <rqiu@vmware.com> 1.2.1-5
93 95
 -   Update make check for bug 1900401
94 96
 *   Wed Jun 07 2017 Xiaolin Li <xiaolinl@vmware.com> 1.2.1-4