Browse code

Refine makefile for chroot & docker build

Change-Id: Ia38636b85ddb3f3a72b2934418cde68985e10cc9
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/3818
Reviewed-by: Vinay Kulkarni <kulkarniv@vmware.com>
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Reviewed-by: Rui Gu <ruig@vmware.com>

Rui Gu authored on 2017/09/20 09:00:45
Showing 2 changed files
... ...
@@ -249,6 +249,30 @@ packages: check-docker-py check-tools $(PHOTON_STAGE) $(PHOTON_PUBLISH_XRPMS) $(
249 249
 		$(PACKAGE_WEIGHTS_PATH) \
250 250
                 -t ${THREADS}
251 251
 
252
+packages-docker: check-docker-py check-docker-service check-tools $(PHOTON_STAGE) $(PHOTON_PUBLISH_XRPMS) $(PHOTON_PUBLISH_RPMS) $(PHOTON_SOURCES) $(CONTAIN) generate-dep-lists
253
+	@echo "Building all RPMS..."
254
+	@cd $(PHOTON_PKG_BUILDER_DIR) && \
255
+        $(PHOTON_PACKAGE_BUILDER) \
256
+                -bt $(PHOTON_BUILD_TYPE) \
257
+                -s $(PHOTON_SPECS_DIR) \
258
+                -r $(PHOTON_RPMS_DIR) \
259
+                -a $(PHOTON_SRPMS_DIR) \
260
+                -x $(PHOTON_SRCS_DIR) \
261
+                -b $(PHOTON_CHROOT_PATH) \
262
+                -l $(PHOTON_LOGS_DIR) \
263
+                -p $(PHOTON_PUBLISH_RPMS_DIR) \
264
+                -e $(PHOTON_PUBLISH_XRPMS_DIR) \
265
+                -c $(PHOTON_PULLSOURCES_CONFIG) \
266
+                -d $(PHOTON_DIST_TAG) \
267
+                -n $(PHOTON_BUILD_NUMBER) \
268
+                -v $(PHOTON_RELEASE_VERSION) \
269
+                -w $(PHOTON_STAGE)/pkg_info.json \
270
+                -g $(PHOTON_DATA_DIR)/pkg_build_options.json \
271
+                $(PHOTON_RPMCHECK_FLAGS) \
272
+		$(PUBLISH_BUILD_DEPENDENCIES) \
273
+		$(PACKAGE_WEIGHTS_PATH) \
274
+                -t ${THREADS}
275
+
252 276
 updated-packages: check-tools $(PHOTON_STAGE) $(PHOTON_PUBLISH_XRPMS) $(PHOTON_PUBLISH_RPMS) $(PHOTON_SOURCES) $(CONTAIN) generate-dep-lists
253 277
 	@echo "Building only updated RPMS..."
254 278
 	@cd $(PHOTON_PKG_BUILDER_DIR) && \
... ...
@@ -491,10 +515,11 @@ check-tools: check-bison check-g++ check-gawk check-createrepo check-texinfo che
491 491
 check-docker:
492 492
 	@command -v docker >/dev/null 2>&1 || { echo "Package docker not installed. Aborting." >&2; exit 1; }
493 493
 
494
+check-docker-service:
495
+	@docker ps >/dev/null 2>&1 || { echo "Docker service is not running. Aborting." >&2; exit 1; }
496
+
494 497
 check-docker-py:
495
-	@tdnf install -y docker docker-py --refresh > /dev/null 2>&1 || { echo "tdnf installation failed. Checking whether docker-py is installed."; } 
496
-	@python -c "import docker; assert docker.__version__ == '2.3.0'" >/dev/null 2>&1 || { echo "Python package docker-py 2.3.0 not installed. Aborting." >&2; exit 1; }
497
-	@systemctl daemon-reload && systemctl start docker
498
+	@python -c "import docker; assert docker.__version__ == '$(PHOTON_DOCKER_PY_VER)'" >/dev/null 2>&1 || { echo "Error: Python package docker-py 2.3.0 not installed.\nPlease use: pip install docker==2.3.0" >&2; exit 1; }
498 499
 
499 500
 check-bison:
500 501
 	@command -v bison >/dev/null 2>&1 || { echo "Package bison not installed. Aborting." >&2; exit 1; }
... ...
@@ -66,5 +66,6 @@ PHOTON_BUILD_NUMBER=$(shell git rev-parse --short HEAD)
66 66
 PHOTON_RELEASE_MAJOR_ID=2.0
67 67
 PHOTON_RELEASE_MINOR_ID=
68 68
 PHOTON_RELEASE_VERSION=$(PHOTON_RELEASE_MAJOR_ID)$(PHOTON_RELEASE_MINOR_ID)
69
+PHOTON_DOCKER_PY_VER=2.3.0
69 70
 
70 71
 PHOTON_PKG_BLACKLIST_FILE=""