From 75393a2d54bcc40053e5262a3de9d70c5ebfbbfd Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Wed, 21 Dec 2022 11:51:23 +0000 Subject: [PATCH 2/2] Fix an attempt to allocate an unreasonably large amount of memory when parsing a corrupt ELF file. PR 29924 * objdump.c (load_specific_debug_section): Check for excessively large sections. --- binutils/ChangeLog | 6 ++++++ binutils/objdump.c | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index aaa9ef72..bb10b609 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2022-12-21 Nick Clifton + + PR 29924 + * objdump.c (load_specific_debug_section): Check for excessively + large sections. + 2022-08-05 Nick Clifton 2.39 Release. diff --git a/binutils/objdump.c b/binutils/objdump.c index b7c71e18..23054657 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -3950,7 +3950,9 @@ load_specific_debug_section (enum dwarf_section_display_enum debug, section->size = bfd_section_size (sec); /* PR 24360: On 32-bit hosts sizeof (size_t) < sizeof (bfd_size_type). */ alloced = amt = section->size + 1; - if (alloced != amt || alloced == 0) + if (alloced != amt + || alloced == 0 + || (bfd_get_size (abfd) != 0 && alloced >= bfd_get_size (abfd))) { section->start = NULL; free_debug_section (debug); -- 2.25.1