Browse code

bb11944 - fix possible message.c OOB read.

Steven Morgan authored on 2017/11/02 05:23:23
Showing 1 changed files
... ...
@@ -2330,15 +2330,16 @@ rfc2231(const char *in)
2330 2330
 						in++;
2331 2331
 						continue;
2332 2332
 					}
2333
-					*p = '\0';
2334 2333
 					break;
2335 2334
 				case '=':
2336 2335
 					/*strcpy(p, in);*/
2337 2336
 					strcpy(p, "=rfc2231failure");
2337
+                                        p += strlen ("=rfc2231failure");
2338 2338
 					break;
2339 2339
 			}
2340 2340
 			break;
2341 2341
 		} while(*in);
2342
+                *p = '\0';
2342 2343
 
2343 2344
 		cli_dbgmsg("RFC2231 parameter continuations are not yet handled, returning \"%s\"\n",
2344 2345
 			ret);