Browse code

Some phishes were getting though that were built with 0.88

git-svn-id: file:///var/lib/svn/clamav-devel/trunk/clamav-devel@2252 77e5149b-7576-45b1-b177-96237e5ba77b

Nigel Horne authored on 2006/09/14 05:55:02
Showing 1 changed files
... ...
@@ -16,7 +16,7 @@
16 16
  *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
17 17
  *  MA 02110-1301, USA.
18 18
  */
19
-static	char	const	rcsid[] = "$Id: message.c,v 1.184 2006/08/29 07:41:59 njh Exp $";
19
+static	char	const	rcsid[] = "$Id: message.c,v 1.185 2006/09/13 20:55:02 njh Exp $";
20 20
 
21 21
 #if HAVE_CONFIG_H
22 22
 #include "clamav-config.h"
... ...
@@ -857,8 +857,14 @@ messageAddStr(message *m, const char *data)
857 857
 	else {
858 858
 		assert(m->body_last != NULL);
859 859
 		if((data == NULL) && (m->body_last->t_line == NULL))
860
-			/* don't save two blank lines in sucession */
861
-			return 1;
860
+			/*
861
+			 * Although this would save time and RAM, some
862
+			 * phish signatures have been built which need the
863
+			 * blank lines
864
+			 */
865
+			if(messageGetMimeType(m) != TEXT)
866
+				/* don't save two blank lines in sucession */
867
+				return 1;
862 868
 
863 869
 		m->body_last->t_next = (text *)cli_malloc(sizeof(text));
864 870
 		if(m->body_last->t_next == NULL) {
... ...
@@ -1410,10 +1416,12 @@ messageExport(message *m, const char *dir, void *(*create)(void), void (*destroy
1410 1410
 					messageAddArgument(m, "name=attachment");
1411 1411
 				} else if(enctype == NOENCODING)
1412 1412
 					/*
1413
-					 * Some virus attachments don't say how they've
1414
-					 * been encoded. We assume base64
1413
+					 * Some virus attachments don't say how
1414
+					 * they've been encoded. We assume
1415
+					 * base64.
1415 1416
 					 *
1416
-					 * FIXME: don't do this if it's a fall through from uuencode
1417
+					 * FIXME: don't do this if it's a fall
1418
+					 * through from uuencode
1417 1419
 					 */
1418 1420
 					messageSetEncoding(m, "base64");
1419 1421
 			}