GitList

Browse code

Revert "bb12107 - 100.1 - fixing oob heap read in mspack"

This reverts commit 867177e3e4a220e0e59fa1af136f5c06800f1fa7.

Reverting in order to apply the upstream libmspack version of the fix for the same bug.

Micah Snyder authored on 2018/08/30 03:59:13
Showing 1 changed files

libclamav/libmspack-0.5alpha/mspack/chmd.c

History View file @ 48c75e6

@@ -626,7 +626,7 @@ static unsigned char *read_chunk(struct mschm_decompressor_p *self,
                          /* ensure chunk cache is available */
                          if (!chm->chunk_cache) {
                     -	size_t size = sizeof(unsigned char *) * (chm->num_chunks + 1);
                     +	size_t size = sizeof(unsigned char *) * chm->num_chunks;
                      	if (!(chm->chunk_cache = (unsigned char **) sys->alloc(sys, size))) {
                      	    self->error = MSPACK_ERR_NOMEMORY;
                      	    return NULL;