Browse code

libclamav, clamd: prune old lockdb code

git-svn: trunk@3955

Tomasz Kojm authored on 2008/07/16 00:55:47
Showing 4 changed files
... ...
@@ -1,3 +1,7 @@
1
+Tue Jul 15 17:30:01 CEST 2008 (tk)
2
+----------------------------------
3
+  * libclamav, clamd: prune old lockdb code
4
+
1 5
 Tue Jul 15 18:25:53 EEST 2008 (edwin)
2 6
 -------------------------------------
3 7
   * configure.in:
... ...
@@ -201,7 +201,7 @@ static struct cl_engine *reload_db(struct cl_engine *engine, unsigned int dbopti
201 201
 {
202 202
 	const char *dbdir;
203 203
 	int retval;
204
-	unsigned int sigs = 0, attempt = 1;
204
+	unsigned int sigs = 0;
205 205
 
206 206
     *ret = 0;
207 207
     if(do_check) {
... ...
@@ -246,10 +246,10 @@ static struct cl_engine *reload_db(struct cl_engine *engine, unsigned int dbopti
246 246
 	return NULL;
247 247
     }
248 248
 
249
-    while((retval = cl_load(dbdir, &engine, &sigs, dboptions)) == CL_ELOCKDB) {
250
-	logg("!reload db failed: %s (attempt %u/3)\n", cl_strerror(retval), attempt);
251
-	if(++attempt > 3)
252
-	    break;
249
+    if((retval = cl_load(dbdir, &engine, &sigs, dboptions))) {
250
+	logg("!reload db failed: %s\n", cl_strerror(retval));
251
+	*ret = 1;
252
+	return NULL;
253 253
     }
254 254
 
255 255
     if(retval) {
... ...
@@ -63,7 +63,6 @@ extern "C"
63 63
 #define CL_EIO		-123 /* general I/O error */
64 64
 #define CL_EFORMAT	-124 /* (internal) bad format or broken file */
65 65
 #define CL_ESUPPORT	-125 /* not supported data format */
66
-#define CL_ELOCKDB	-126 /* can't lock DB directory */
67 66
 #define CL_EARJ         -127 /* ARJ handler error */
68 67
 
69 68
 /* db options */
... ...
@@ -191,8 +191,6 @@ const char *cl_strerror(int clerror)
191 191
 	    return "Bad format or broken data";
192 192
 	case CL_ESUPPORT:
193 193
 	    return "Not supported data format";
194
-	case CL_ELOCKDB:
195
-	    return "Unable to lock database directory";
196 194
 	case CL_EARJ:
197 195
 	    return "ARJ module failure";
198 196
 	default: