Browse code

Handle % characters in e-mail addresses

git-svn-id: file:///var/lib/svn/clamav-devel/trunk/clamav-devel@108 77e5149b-7576-45b1-b177-96237e5ba77b

Nigel Horne authored on 2003/11/11 17:22:27
Showing 3 changed files
... ...
@@ -1,3 +1,8 @@
1
+Tue Nov 11 13:51:23 IST 2003 (njh)
2
+----------------------------------
3
+  * clamav-milter: Fixed handling of % characters in e-mail addresses
4
+		pointed out by dotslash@snosoft.com
5
+		
1 6
 Sun Nov  9 20:25:11 CET 2003 (tk)
2 7
 ---------------------------------
3 8
   * libclamav: some functions were still using SCANBUFF instead of FILEBUFF,
... ...
@@ -143,6 +143,8 @@ Changes
143 143
 		fails (Joe Talbott <josepht@cstone.net>)
144 144
 0.60p	5/11/03	Only call mutex_unlock when max_children is set
145 145
 		Tidy up the call to pthread_cond_timedwait
146
+0.60q	11/11/03 Fixed handling of % characters in e-mail addresses
147
+		pointed out by dotslash@snosoft.com
146 148
 
147 149
 BUG REPORTS
148 150
 
... ...
@@ -148,9 +148,14 @@
148 148
  *			fails (Joe Talbott <josepht@cstone.net>)
149 149
  *	0.60p	5/11/03	Only call mutex_unlock when max_children is set
150 150
  *			Tidy up the call to pthread_cond_timedwait
151
+ *	0.60q	11/11/03 Fixed handling of % characters in e-mail addresses
152
+ *			pointed out by dotslash@snosoft.com
151 153
  *
152 154
  * Change History:
153 155
  * $Log: clamav-milter.c,v $
156
+ * Revision 1.18  2003/11/11 08:19:20  nigelhorne
157
+ * Handle % characters in e-mail addresses
158
+ *
154 159
  * Revision 1.17  2003/11/05 15:41:11  nigelhorne
155 160
  * Tidyup pthread_cond_timewait call
156 161
  *
... ...
@@ -186,9 +191,8 @@
186 186
  *
187 187
  * Revision 1.6  2003/09/28 16:37:23  nigelhorne
188 188
  * Added -f flag use MaxThreads if --max-children not set
189
- *
190 189
  */
191
-static	char	const	rcsid[] = "$Id: clamav-milter.c,v 1.17 2003/11/05 15:41:11 nigelhorne Exp $";
190
+static	char	const	rcsid[] = "$Id: clamav-milter.c,v 1.18 2003/11/11 08:19:20 nigelhorne Exp $";
192 191
 
193 192
 #define	CM_VERSION	"0.60p"
194 193
 
... ...
@@ -1228,7 +1232,12 @@ clamfi_eom(SMFICTX *ctx)
1228 1228
 		(void)strcpy(ptr, "\n");
1229 1229
 
1230 1230
 		if(use_syslog)
1231
-			syslog(LOG_NOTICE, err);
1231
+			/*
1232
+			 * The "%s" is there to plug a remote possibility
1233
+			 * of the program crashing if an e-mail address
1234
+			 * contains a percent character
1235
+			 */
1236
+			syslog(LOG_NOTICE, "%s", err);
1232 1237
 #ifdef	CL_DEBUG
1233 1238
 		puts(err);
1234 1239
 #endif