Browse code

mspack - maintainability improvments for cabd OOB fix

Mickey Sola authored on 2017/07/21 04:05:45
Showing 1 changed files
... ...
@@ -525,7 +525,8 @@ static char *cabd_read_string(struct mspack_system *sys,
525 525
   ssize_t len;
526 526
 
527 527
   /* read up to 256 bytes */
528
-  if ( !(len = sys->read(fh, &buf[0], 256) > 0)) {
528
+  len = sys->read(fh, &buf[0], 256);
529
+  if (len <= 0) {
529 530
       *error = MSPACK_ERR_READ;
530 531
       return NULL;
531 532
   }