| 0a8386c8 |
// This file will be removed when we completely drop support for
// passing HostConfig to container start API.
package main
import (
"net/http"
"strings"
|
| 33968e6c |
"github.com/docker/docker/integration-cli/checker" |
| d69d4799 |
"github.com/docker/docker/integration-cli/request" |
| 0a8386c8 |
"github.com/go-check/check"
)
func formatV123StartAPIURL(url string) string {
return "/v1.23" + url
}
|
| 7fb7a477 |
func (s *DockerSuite) TestDeprecatedContainerAPIStartHostConfig(c *check.C) { |
| 0a8386c8 |
name := "test-deprecated-api-124"
dockerCmd(c, "create", "--name", name, "busybox")
config := map[string]interface{}{
"Binds": []string{"/aa:/bb"},
} |
| 0fd5a654 |
res, body, err := request.Post("/containers/"+name+"/start", request.JSONBody(config)) |
| 0a8386c8 |
c.Assert(err, checker.IsNil) |
| 0fd5a654 |
buf, err := request.ReadBody(body)
c.Assert(err, checker.IsNil)
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest)
c.Assert(string(buf), checker.Contains, "was deprecated since API v1.22") |
| 0a8386c8 |
}
|
| 7fb7a477 |
func (s *DockerSuite) TestDeprecatedContainerAPIStartVolumeBinds(c *check.C) { |
| 0a8386c8 |
// TODO Windows CI: Investigate further why this fails on Windows to Windows CI.
testRequires(c, DaemonIsLinux)
path := "/foo" |
| 18a771a7 |
if testEnv.OSType == "windows" { |
| 0a8386c8 |
path = `c:\foo`
}
name := "testing"
config := map[string]interface{}{
"Image": "busybox",
"Volumes": map[string]struct{}{path: {}},
}
|
| 0fd5a654 |
res, _, err := request.Post(formatV123StartAPIURL("/containers/create?name="+name), request.JSONBody(config)) |
| 0a8386c8 |
c.Assert(err, checker.IsNil) |
| 0fd5a654 |
c.Assert(res.StatusCode, checker.Equals, http.StatusCreated) |
| 0a8386c8 |
|
| 18a771a7 |
bindPath := RandomTmpDirPath("test", testEnv.OSType) |
| 0a8386c8 |
config = map[string]interface{}{
"Binds": []string{bindPath + ":" + path},
} |
| 0fd5a654 |
res, _, err = request.Post(formatV123StartAPIURL("/containers/"+name+"/start"), request.JSONBody(config)) |
| 0a8386c8 |
c.Assert(err, checker.IsNil) |
| 0fd5a654 |
c.Assert(res.StatusCode, checker.Equals, http.StatusNoContent) |
| 0a8386c8 |
pth, err := inspectMountSourceField(name, path)
c.Assert(err, checker.IsNil)
c.Assert(pth, checker.Equals, bindPath, check.Commentf("expected volume host path to be %s, got %s", bindPath, pth))
}
// Test for GH#10618 |
| 7fb7a477 |
func (s *DockerSuite) TestDeprecatedContainerAPIStartDupVolumeBinds(c *check.C) { |
| 0a8386c8 |
// TODO Windows to Windows CI - Port this
testRequires(c, DaemonIsLinux)
name := "testdups"
config := map[string]interface{}{
"Image": "busybox",
"Volumes": map[string]struct{}{"/tmp": {}},
}
|
| 0fd5a654 |
res, _, err := request.Post(formatV123StartAPIURL("/containers/create?name="+name), request.JSONBody(config)) |
| 0a8386c8 |
c.Assert(err, checker.IsNil) |
| 0fd5a654 |
c.Assert(res.StatusCode, checker.Equals, http.StatusCreated) |
| 0a8386c8 |
|
| 18a771a7 |
bindPath1 := RandomTmpDirPath("test1", testEnv.OSType)
bindPath2 := RandomTmpDirPath("test2", testEnv.OSType) |
| 0a8386c8 |
config = map[string]interface{}{
"Binds": []string{bindPath1 + ":/tmp", bindPath2 + ":/tmp"},
} |
| 0fd5a654 |
res, body, err := request.Post(formatV123StartAPIURL("/containers/"+name+"/start"), request.JSONBody(config)) |
| 0a8386c8 |
c.Assert(err, checker.IsNil) |
| 0fd5a654 |
buf, err := request.ReadBody(body)
c.Assert(err, checker.IsNil)
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest)
c.Assert(string(buf), checker.Contains, "Duplicate mount point", check.Commentf("Expected failure due to duplicate bind mounts to same path, instead got: %q with error: %v", string(buf), err)) |
| 0a8386c8 |
}
|
| 7fb7a477 |
func (s *DockerSuite) TestDeprecatedContainerAPIStartVolumesFrom(c *check.C) { |
| 0a8386c8 |
// TODO Windows to Windows CI - Port this
testRequires(c, DaemonIsLinux)
volName := "voltst"
volPath := "/tmp"
dockerCmd(c, "run", "--name", volName, "-v", volPath, "busybox")
|
| 7fb7a477 |
name := "TestContainerAPIStartVolumesFrom" |
| 0a8386c8 |
config := map[string]interface{}{
"Image": "busybox",
"Volumes": map[string]struct{}{volPath: {}},
}
|
| 0fd5a654 |
res, _, err := request.Post(formatV123StartAPIURL("/containers/create?name="+name), request.JSONBody(config)) |
| 0a8386c8 |
c.Assert(err, checker.IsNil) |
| 0fd5a654 |
c.Assert(res.StatusCode, checker.Equals, http.StatusCreated) |
| 0a8386c8 |
config = map[string]interface{}{
"VolumesFrom": []string{volName},
} |
| 0fd5a654 |
res, _, err = request.Post(formatV123StartAPIURL("/containers/"+name+"/start"), request.JSONBody(config)) |
| 0a8386c8 |
c.Assert(err, checker.IsNil) |
| 0fd5a654 |
c.Assert(res.StatusCode, checker.Equals, http.StatusNoContent) |
| 0a8386c8 |
pth, err := inspectMountSourceField(name, volPath)
c.Assert(err, checker.IsNil)
pth2, err := inspectMountSourceField(volName, volPath)
c.Assert(err, checker.IsNil)
c.Assert(pth, checker.Equals, pth2, check.Commentf("expected volume host path to be %s, got %s", pth, pth2))
}
// #9981 - Allow a docker created volume (ie, one in /var/lib/docker/volumes) to be used to overwrite (via passing in Binds on api start) an existing volume
func (s *DockerSuite) TestDeprecatedPostContainerBindNormalVolume(c *check.C) {
// TODO Windows to Windows CI - Port this
testRequires(c, DaemonIsLinux)
dockerCmd(c, "create", "-v", "/foo", "--name=one", "busybox")
fooDir, err := inspectMountSourceField("one", "/foo")
c.Assert(err, checker.IsNil)
dockerCmd(c, "create", "-v", "/foo", "--name=two", "busybox")
bindSpec := map[string][]string{"Binds": {fooDir + ":/foo"}} |
| 0fd5a654 |
res, _, err := request.Post(formatV123StartAPIURL("/containers/two/start"), request.JSONBody(bindSpec)) |
| 0a8386c8 |
c.Assert(err, checker.IsNil) |
| 0fd5a654 |
c.Assert(res.StatusCode, checker.Equals, http.StatusNoContent) |
| 0a8386c8 |
fooDir2, err := inspectMountSourceField("two", "/foo")
c.Assert(err, checker.IsNil)
c.Assert(fooDir2, checker.Equals, fooDir, check.Commentf("expected volume path to be %s, got: %s", fooDir, fooDir2))
}
func (s *DockerSuite) TestDeprecatedStartWithTooLowMemoryLimit(c *check.C) {
// TODO Windows: Port once memory is supported
testRequires(c, DaemonIsLinux)
out, _ := dockerCmd(c, "create", "busybox")
containerID := strings.TrimSpace(out)
config := `{
"CpuShares": 100,
"Memory": 524287
}`
|
| b11ba123 |
res, body, err := request.Post(formatV123StartAPIURL("/containers/"+containerID+"/start"), request.RawString(config), request.JSON) |
| 0a8386c8 |
c.Assert(err, checker.IsNil) |
| 4f304e72 |
b, err2 := request.ReadBody(body) |
| 0a8386c8 |
c.Assert(err2, checker.IsNil) |
| ebcb7d6b |
c.Assert(res.StatusCode, checker.Equals, http.StatusBadRequest) |
| 0a8386c8 |
c.Assert(string(b), checker.Contains, "Minimum memory limit allowed is 4MB")
}
// #14640
func (s *DockerSuite) TestDeprecatedPostContainersStartWithoutLinksInHostConfig(c *check.C) {
// TODO Windows: Windows doesn't support supplying a hostconfig on start.
// An alternate test could be written to validate the negative testing aspect of this
testRequires(c, DaemonIsLinux)
name := "test-host-config-links" |
| 52f04748 |
dockerCmd(c, append([]string{"create", "--name", name, "busybox"}, sleepCommandForDaemonPlatform()...)...) |
| 0a8386c8 |
hc := inspectFieldJSON(c, name, "HostConfig")
config := `{"HostConfig":` + hc + `}`
|
| b11ba123 |
res, b, err := request.Post(formatV123StartAPIURL("/containers/"+name+"/start"), request.RawString(config), request.JSON) |
| 0a8386c8 |
c.Assert(err, checker.IsNil)
c.Assert(res.StatusCode, checker.Equals, http.StatusNoContent)
b.Close()
}
// #14640
func (s *DockerSuite) TestDeprecatedPostContainersStartWithLinksInHostConfig(c *check.C) {
// TODO Windows: Windows doesn't support supplying a hostconfig on start.
// An alternate test could be written to validate the negative testing aspect of this
testRequires(c, DaemonIsLinux)
name := "test-host-config-links"
dockerCmd(c, "run", "--name", "foo", "-d", "busybox", "top")
dockerCmd(c, "create", "--name", name, "--link", "foo:bar", "busybox", "top")
hc := inspectFieldJSON(c, name, "HostConfig")
config := `{"HostConfig":` + hc + `}`
|
| b11ba123 |
res, b, err := request.Post(formatV123StartAPIURL("/containers/"+name+"/start"), request.RawString(config), request.JSON) |
| 0a8386c8 |
c.Assert(err, checker.IsNil)
c.Assert(res.StatusCode, checker.Equals, http.StatusNoContent)
b.Close()
}
// #14640
func (s *DockerSuite) TestDeprecatedPostContainersStartWithLinksInHostConfigIdLinked(c *check.C) {
// Windows does not support links
testRequires(c, DaemonIsLinux)
name := "test-host-config-links"
out, _ := dockerCmd(c, "run", "--name", "link0", "-d", "busybox", "top") |
| ddae20c0 |
defer dockerCmd(c, "stop", "link0") |
| 0a8386c8 |
id := strings.TrimSpace(out)
dockerCmd(c, "create", "--name", name, "--link", id, "busybox", "top") |
| ddae20c0 |
defer dockerCmd(c, "stop", name) |
| 0a8386c8 |
hc := inspectFieldJSON(c, name, "HostConfig")
config := `{"HostConfig":` + hc + `}`
|
| b11ba123 |
res, b, err := request.Post(formatV123StartAPIURL("/containers/"+name+"/start"), request.RawString(config), request.JSON) |
| 0a8386c8 |
c.Assert(err, checker.IsNil)
c.Assert(res.StatusCode, checker.Equals, http.StatusNoContent)
b.Close()
}
func (s *DockerSuite) TestDeprecatedStartWithNilDNS(c *check.C) {
// TODO Windows: Add once DNS is supported
testRequires(c, DaemonIsLinux)
out, _ := dockerCmd(c, "create", "busybox")
containerID := strings.TrimSpace(out)
config := `{"HostConfig": {"Dns": null}}`
|
| b11ba123 |
res, b, err := request.Post(formatV123StartAPIURL("/containers/"+containerID+"/start"), request.RawString(config), request.JSON) |
| 0a8386c8 |
c.Assert(err, checker.IsNil)
c.Assert(res.StatusCode, checker.Equals, http.StatusNoContent)
b.Close()
dns := inspectFieldJSON(c, containerID, "HostConfig.Dns")
c.Assert(dns, checker.Equals, "[]")
} |