integration-cli/docker_cli_external_volume_driver_unix_test.go
81fa9feb
 // +build !windows
 
 package main
 
 import (
 	"encoding/json"
 	"fmt"
9f19cbc2
 	"io"
81fa9feb
 	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
 	"os"
0ef740a5
 	"os/exec"
81fa9feb
 	"path/filepath"
 	"strings"
0ef740a5
 	"time"
81fa9feb
 
91e197d6
 	"github.com/docker/docker/api/types"
33968e6c
 	"github.com/docker/docker/integration-cli/checker"
48de91a3
 	"github.com/docker/docker/integration-cli/daemon"
6a0bdffc
 	"github.com/docker/docker/pkg/stringid"
2f40b1b2
 	"github.com/docker/docker/volume"
81fa9feb
 	"github.com/go-check/check"
 )
 
6a0bdffc
 const volumePluginName = "test-external-volume-driver"
 
81fa9feb
 func init() {
d592778f
 	check.Suite(&DockerExternalVolumeSuite{
81fa9feb
 		ds: &DockerSuite{},
 	})
 }
 
d592778f
 type eventCounter struct {
 	activations int
 	creations   int
 	removals    int
 	mounts      int
 	unmounts    int
 	paths       int
d3eca445
 	lists       int
 	gets        int
2f40b1b2
 	caps        int
d592778f
 }
 
 type DockerExternalVolumeSuite struct {
6a0bdffc
 	ds *DockerSuite
48de91a3
 	d  *daemon.Daemon
6a0bdffc
 	*volumePlugin
81fa9feb
 }
 
d592778f
 func (s *DockerExternalVolumeSuite) SetUpTest(c *check.C) {
48de91a3
 	s.d = daemon.New(c, dockerBinary, dockerdBinary, daemon.Config{
c8016e66
 		Experimental: testEnv.ExperimentalDaemon(),
48de91a3
 	})
d592778f
 	s.ec = &eventCounter{}
81fa9feb
 }
 
d592778f
 func (s *DockerExternalVolumeSuite) TearDownTest(c *check.C) {
5890091c
 	if s.d != nil {
c502fb49
 		s.d.Stop(c)
5890091c
 		s.ds.TearDownTest(c)
 	}
81fa9feb
 }
 
d592778f
 func (s *DockerExternalVolumeSuite) SetUpSuite(c *check.C) {
6a0bdffc
 	s.volumePlugin = newVolumePlugin(c, volumePluginName)
 }
 
 type volumePlugin struct {
 	ec *eventCounter
 	*httptest.Server
 	vols map[string]vol
 }
 
 type vol struct {
 	Name       string
 	Mountpoint string
 	Ninja      bool // hack used to trigger a null volume return on `Get`
 	Status     map[string]interface{}
9a2d0bc3
 	Options    map[string]string
6a0bdffc
 }
 
 func (p *volumePlugin) Close() {
 	p.Server.Close()
 }
 
 func newVolumePlugin(c *check.C, name string) *volumePlugin {
81fa9feb
 	mux := http.NewServeMux()
6a0bdffc
 	s := &volumePlugin{Server: httptest.NewServer(mux), ec: &eventCounter{}, vols: make(map[string]vol)}
81fa9feb
 
 	type pluginRequest struct {
9f19cbc2
 		Name string
96c79a19
 		Opts map[string]string
2b6bc294
 		ID   string
9f19cbc2
 	}
 
 	type pluginResp struct {
 		Mountpoint string `json:",omitempty"`
 		Err        string `json:",omitempty"`
 	}
 
 	read := func(b io.ReadCloser) (pluginRequest, error) {
 		defer b.Close()
 		var pr pluginRequest
2c187a24
 		err := json.NewDecoder(b).Decode(&pr)
 		return pr, err
9f19cbc2
 	}
 
 	send := func(w http.ResponseWriter, data interface{}) {
 		switch t := data.(type) {
 		case error:
 			http.Error(w, t.Error(), 500)
 		case string:
 			w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
 			fmt.Fprintln(w, t)
 		default:
 			w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
 			json.NewEncoder(w).Encode(&data)
 		}
81fa9feb
 	}
 
 	mux.HandleFunc("/Plugin.Activate", func(w http.ResponseWriter, r *http.Request) {
d592778f
 		s.ec.activations++
9f19cbc2
 		send(w, `{"Implements": ["VolumeDriver"]}`)
81fa9feb
 	})
 
 	mux.HandleFunc("/VolumeDriver.Create", func(w http.ResponseWriter, r *http.Request) {
d592778f
 		s.ec.creations++
d3eca445
 		pr, err := read(r.Body)
 		if err != nil {
 			send(w, err)
 			return
 		}
96c79a19
 		_, isNinja := pr.Opts["ninja"]
36a1c56c
 		status := map[string]interface{}{"Hello": "world"}
9a2d0bc3
 		s.vols[pr.Name] = vol{Name: pr.Name, Ninja: isNinja, Status: status, Options: pr.Opts}
d3eca445
 		send(w, nil)
 	})
d592778f
 
d3eca445
 	mux.HandleFunc("/VolumeDriver.List", func(w http.ResponseWriter, r *http.Request) {
 		s.ec.lists++
6a0bdffc
 		vols := make([]vol, 0, len(s.vols))
 		for _, v := range s.vols {
928bfd07
 			if v.Ninja {
 				continue
 			}
 			vols = append(vols, v)
 		}
 		send(w, map[string][]vol{"Volumes": vols})
d3eca445
 	})
 
 	mux.HandleFunc("/VolumeDriver.Get", func(w http.ResponseWriter, r *http.Request) {
 		s.ec.gets++
 		pr, err := read(r.Body)
9f19cbc2
 		if err != nil {
 			send(w, err)
 			return
 		}
 
6a0bdffc
 		v, exists := s.vols[pr.Name]
 		if !exists {
 			send(w, `{"Err": "no such volume"}`)
 		}
36a1c56c
 
6a0bdffc
 		if v.Ninja {
 			send(w, map[string]vol{})
 			return
d3eca445
 		}
6a0bdffc
 
 		v.Mountpoint = hostVolumePath(pr.Name)
 		send(w, map[string]vol{"Volume": v})
 		return
81fa9feb
 	})
 
 	mux.HandleFunc("/VolumeDriver.Remove", func(w http.ResponseWriter, r *http.Request) {
d592778f
 		s.ec.removals++
9f19cbc2
 		pr, err := read(r.Body)
 		if err != nil {
 			send(w, err)
 			return
 		}
d3eca445
 
6a0bdffc
 		v, ok := s.vols[pr.Name]
 		if !ok {
 			send(w, nil)
 			return
 		}
 
 		if err := os.RemoveAll(hostVolumePath(v.Name)); err != nil {
 			send(w, &pluginResp{Err: err.Error()})
 			return
d3eca445
 		}
6a0bdffc
 		delete(s.vols, v.Name)
9f19cbc2
 		send(w, nil)
81fa9feb
 	})
 
 	mux.HandleFunc("/VolumeDriver.Path", func(w http.ResponseWriter, r *http.Request) {
d592778f
 		s.ec.paths++
 
9f19cbc2
 		pr, err := read(r.Body)
 		if err != nil {
 			send(w, err)
 			return
81fa9feb
 		}
9f19cbc2
 		p := hostVolumePath(pr.Name)
d3eca445
 		send(w, &pluginResp{Mountpoint: p})
81fa9feb
 	})
 
 	mux.HandleFunc("/VolumeDriver.Mount", func(w http.ResponseWriter, r *http.Request) {
d592778f
 		s.ec.mounts++
 
9f19cbc2
 		pr, err := read(r.Body)
 		if err != nil {
 			send(w, err)
 			return
81fa9feb
 		}
 
9a2d0bc3
 		if v, exists := s.vols[pr.Name]; exists {
 			// Use this to simulate a mount failure
 			if _, exists := v.Options["invalidOption"]; exists {
 				send(w, fmt.Errorf("invalid argument"))
 				return
 			}
 		}
 
9f19cbc2
 		p := hostVolumePath(pr.Name)
81fa9feb
 		if err := os.MkdirAll(p, 0755); err != nil {
9f19cbc2
 			send(w, &pluginResp{Err: err.Error()})
 			return
81fa9feb
 		}
 
6a0bdffc
 		if err := ioutil.WriteFile(filepath.Join(p, "test"), []byte(s.Server.URL), 0644); err != nil {
9f19cbc2
 			send(w, err)
 			return
81fa9feb
 		}
 
2b6bc294
 		if err := ioutil.WriteFile(filepath.Join(p, "mountID"), []byte(pr.ID), 0644); err != nil {
 			send(w, err)
 			return
 		}
 
9f19cbc2
 		send(w, &pluginResp{Mountpoint: p})
81fa9feb
 	})
 
d592778f
 	mux.HandleFunc("/VolumeDriver.Unmount", func(w http.ResponseWriter, r *http.Request) {
 		s.ec.unmounts++
 
9f19cbc2
 		_, err := read(r.Body)
 		if err != nil {
 			send(w, err)
 			return
81fa9feb
 		}
 
d3eca445
 		send(w, nil)
81fa9feb
 	})
 
2f40b1b2
 	mux.HandleFunc("/VolumeDriver.Capabilities", func(w http.ResponseWriter, r *http.Request) {
 		s.ec.caps++
 
 		_, err := read(r.Body)
 		if err != nil {
 			send(w, err)
 			return
 		}
 
 		send(w, `{"Capabilities": { "Scope": "global" }}`)
 	})
 
a91a874f
 	err := os.MkdirAll("/etc/docker/plugins", 0755)
 	c.Assert(err, checker.IsNil)
81fa9feb
 
6a0bdffc
 	err = ioutil.WriteFile("/etc/docker/plugins/"+name+".spec", []byte(s.Server.URL), 0644)
a91a874f
 	c.Assert(err, checker.IsNil)
6a0bdffc
 	return s
81fa9feb
 }
 
d592778f
 func (s *DockerExternalVolumeSuite) TearDownSuite(c *check.C) {
6a0bdffc
 	s.volumePlugin.Close()
81fa9feb
 
a91a874f
 	err := os.RemoveAll("/etc/docker/plugins")
 	c.Assert(err, checker.IsNil)
81fa9feb
 }
 
53d447c5
 func (s *DockerExternalVolumeSuite) TestVolumeCLICreateOptionConflict(c *check.C) {
 	dockerCmd(c, "volume", "create", "test")
 
 	out, _, err := dockerCmdWithError("volume", "create", "test", "--driver", volumePluginName)
 	c.Assert(err, check.NotNil, check.Commentf("volume create exception name already in use with another driver"))
 	c.Assert(out, checker.Contains, "A volume named test already exists")
 
 	out, _ = dockerCmd(c, "volume", "inspect", "--format={{ .Driver }}", "test")
 	_, _, err = dockerCmdWithError("volume", "create", "test", "--driver", strings.TrimSpace(out))
 	c.Assert(err, check.IsNil)
 }
 
9f19cbc2
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverNamed(c *check.C) {
c502fb49
 	s.d.StartWithBusybox(c)
d592778f
 
6a0bdffc
 	out, err := s.d.Cmd("run", "--rm", "--name", "test-data", "-v", "external-volume-test:/tmp/external-volume-test", "--volume-driver", volumePluginName, "busybox:latest", "cat", "/tmp/external-volume-test/test")
9f19cbc2
 	c.Assert(err, checker.IsNil, check.Commentf(out))
6a0bdffc
 	c.Assert(out, checker.Contains, s.Server.URL)
d592778f
 
dd7d1c8a
 	_, err = s.d.Cmd("volume", "rm", "external-volume-test")
 	c.Assert(err, checker.IsNil)
 
d592778f
 	p := hostVolumePath("external-volume-test")
 	_, err = os.Lstat(p)
a91a874f
 	c.Assert(err, checker.NotNil)
9f19cbc2
 	c.Assert(os.IsNotExist(err), checker.True, check.Commentf("Expected volume path in host to not exist: %s, %v\n", p, err))
d592778f
 
a91a874f
 	c.Assert(s.ec.activations, checker.Equals, 1)
 	c.Assert(s.ec.creations, checker.Equals, 1)
 	c.Assert(s.ec.removals, checker.Equals, 1)
 	c.Assert(s.ec.mounts, checker.Equals, 1)
 	c.Assert(s.ec.unmounts, checker.Equals, 1)
d592778f
 }
 
9f19cbc2
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverUnnamed(c *check.C) {
c502fb49
 	s.d.StartWithBusybox(c)
d592778f
 
6a0bdffc
 	out, err := s.d.Cmd("run", "--rm", "--name", "test-data", "-v", "/tmp/external-volume-test", "--volume-driver", volumePluginName, "busybox:latest", "cat", "/tmp/external-volume-test/test")
9f19cbc2
 	c.Assert(err, checker.IsNil, check.Commentf(out))
6a0bdffc
 	c.Assert(out, checker.Contains, s.Server.URL)
d592778f
 
a91a874f
 	c.Assert(s.ec.activations, checker.Equals, 1)
 	c.Assert(s.ec.creations, checker.Equals, 1)
 	c.Assert(s.ec.removals, checker.Equals, 1)
 	c.Assert(s.ec.mounts, checker.Equals, 1)
 	c.Assert(s.ec.unmounts, checker.Equals, 1)
d592778f
 }
 
928bfd07
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverVolumesFrom(c *check.C) {
c502fb49
 	s.d.StartWithBusybox(c)
d592778f
 
6a0bdffc
 	out, err := s.d.Cmd("run", "--name", "vol-test1", "-v", "/foo", "--volume-driver", volumePluginName, "busybox:latest")
a91a874f
 	c.Assert(err, checker.IsNil, check.Commentf(out))
d592778f
 
b3b7eb27
 	out, err = s.d.Cmd("run", "--rm", "--volumes-from", "vol-test1", "--name", "vol-test2", "busybox", "ls", "/tmp")
a91a874f
 	c.Assert(err, checker.IsNil, check.Commentf(out))
d592778f
 
b3b7eb27
 	out, err = s.d.Cmd("rm", "-fv", "vol-test1")
a91a874f
 	c.Assert(err, checker.IsNil, check.Commentf(out))
d592778f
 
a91a874f
 	c.Assert(s.ec.activations, checker.Equals, 1)
 	c.Assert(s.ec.creations, checker.Equals, 1)
 	c.Assert(s.ec.removals, checker.Equals, 1)
 	c.Assert(s.ec.mounts, checker.Equals, 2)
 	c.Assert(s.ec.unmounts, checker.Equals, 2)
d592778f
 }
 
928bfd07
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverDeleteContainer(c *check.C) {
c502fb49
 	s.d.StartWithBusybox(c)
d592778f
 
6a0bdffc
 	out, err := s.d.Cmd("run", "--name", "vol-test1", "-v", "/foo", "--volume-driver", volumePluginName, "busybox:latest")
a91a874f
 	c.Assert(err, checker.IsNil, check.Commentf(out))
d592778f
 
a91a874f
 	out, err = s.d.Cmd("rm", "-fv", "vol-test1")
 	c.Assert(err, checker.IsNil, check.Commentf(out))
d592778f
 
a91a874f
 	c.Assert(s.ec.activations, checker.Equals, 1)
 	c.Assert(s.ec.creations, checker.Equals, 1)
 	c.Assert(s.ec.removals, checker.Equals, 1)
 	c.Assert(s.ec.mounts, checker.Equals, 1)
 	c.Assert(s.ec.unmounts, checker.Equals, 1)
d592778f
 }
 
 func hostVolumePath(name string) string {
 	return fmt.Sprintf("/var/lib/docker/volumes/%s", name)
81fa9feb
 }
6b8129d1
 
0ef740a5
 // Make sure a request to use a down driver doesn't block other requests
9f19cbc2
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverLookupNotBlocked(c *check.C) {
0ef740a5
 	specPath := "/etc/docker/plugins/down-driver.spec"
d3eca445
 	err := ioutil.WriteFile(specPath, []byte("tcp://127.0.0.7:9999"), 0644)
 	c.Assert(err, check.IsNil)
0ef740a5
 	defer os.RemoveAll(specPath)
 
 	chCmd1 := make(chan struct{})
 	chCmd2 := make(chan error)
 	cmd1 := exec.Command(dockerBinary, "volume", "create", "-d", "down-driver")
 	cmd2 := exec.Command(dockerBinary, "volume", "create")
 
a91a874f
 	c.Assert(cmd1.Start(), checker.IsNil)
0ef740a5
 	defer cmd1.Process.Kill()
 	time.Sleep(100 * time.Millisecond) // ensure API has been called
a91a874f
 	c.Assert(cmd2.Start(), checker.IsNil)
0ef740a5
 
 	go func() {
 		cmd1.Wait()
 		close(chCmd1)
 	}()
 	go func() {
 		chCmd2 <- cmd2.Wait()
 	}()
 
 	select {
 	case <-chCmd1:
 		cmd2.Process.Kill()
 		c.Fatalf("volume create with down driver finished unexpectedly")
 	case err := <-chCmd2:
a91a874f
 		c.Assert(err, checker.IsNil)
0ef740a5
 	case <-time.After(5 * time.Second):
 		cmd2.Process.Kill()
d3eca445
 		c.Fatal("volume creates are blocked by previous create requests when previous driver is down")
0ef740a5
 	}
 }
d3eca445
 
9f19cbc2
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverRetryNotImmediatelyExists(c *check.C) {
c502fb49
 	s.d.StartWithBusybox(c)
4bd4d18e
 	driverName := "test-external-volume-driver-retry"
45fdce8a
 
 	errchan := make(chan error)
4bd4d18e
 	started := make(chan struct{})
45fdce8a
 	go func() {
4bd4d18e
 		close(started)
 		if out, err := s.d.Cmd("run", "--rm", "--name", "test-data-retry", "-v", "external-volume-test:/tmp/external-volume-test", "--volume-driver", driverName, "busybox:latest"); err != nil {
45fdce8a
 			errchan <- fmt.Errorf("%v:\n%s", err, out)
 		}
 		close(errchan)
 	}()
4bd4d18e
 
 	<-started
 	// wait for a retry to occur, then create spec to allow plugin to register
cbf2f4d2
 	time.Sleep(2 * time.Second)
4bd4d18e
 	p := newVolumePlugin(c, driverName)
 	defer p.Close()
45fdce8a
 
 	select {
 	case err := <-errchan:
a91a874f
 		c.Assert(err, checker.IsNil)
45fdce8a
 	case <-time.After(8 * time.Second):
 		c.Fatal("volume creates fail when plugin not immediately available")
 	}
 
c502fb49
 	_, err := s.d.Cmd("volume", "rm", "external-volume-test")
dd7d1c8a
 	c.Assert(err, checker.IsNil)
 
4bd4d18e
 	c.Assert(p.ec.activations, checker.Equals, 1)
 	c.Assert(p.ec.creations, checker.Equals, 1)
 	c.Assert(p.ec.removals, checker.Equals, 1)
 	c.Assert(p.ec.mounts, checker.Equals, 1)
 	c.Assert(p.ec.unmounts, checker.Equals, 1)
45fdce8a
 }
39be3665
 
9f19cbc2
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverBindExternalVolume(c *check.C) {
6a0bdffc
 	dockerCmd(c, "volume", "create", "-d", volumePluginName, "foo")
39be3665
 	dockerCmd(c, "run", "-d", "--name", "testing", "-v", "foo:/bar", "busybox", "top")
 
 	var mounts []struct {
 		Name   string
 		Driver string
 	}
62a856e9
 	out := inspectFieldJSON(c, "testing", "Mounts")
a91a874f
 	c.Assert(json.NewDecoder(strings.NewReader(out)).Decode(&mounts), checker.IsNil)
 	c.Assert(len(mounts), checker.Equals, 1, check.Commentf(out))
 	c.Assert(mounts[0].Name, checker.Equals, "foo")
6a0bdffc
 	c.Assert(mounts[0].Driver, checker.Equals, volumePluginName)
39be3665
 }
d3eca445
 
928bfd07
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverList(c *check.C) {
6a0bdffc
 	dockerCmd(c, "volume", "create", "-d", volumePluginName, "abc3")
d3eca445
 	out, _ := dockerCmd(c, "volume", "ls")
 	ls := strings.Split(strings.TrimSpace(out), "\n")
 	c.Assert(len(ls), check.Equals, 2, check.Commentf("\n%s", out))
 
 	vol := strings.Fields(ls[len(ls)-1])
 	c.Assert(len(vol), check.Equals, 2, check.Commentf("%v", vol))
6a0bdffc
 	c.Assert(vol[0], check.Equals, volumePluginName)
928bfd07
 	c.Assert(vol[1], check.Equals, "abc3")
d3eca445
 
 	c.Assert(s.ec.lists, check.Equals, 1)
 }
 
dd7d1c8a
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverGet(c *check.C) {
d3eca445
 	out, _, err := dockerCmdWithError("volume", "inspect", "dummy")
 	c.Assert(err, check.NotNil, check.Commentf(out))
 	c.Assert(out, checker.Contains, "No such volume")
6a0bdffc
 	c.Assert(s.ec.gets, check.Equals, 1)
36a1c56c
 
6a0bdffc
 	dockerCmd(c, "volume", "create", "test", "-d", volumePluginName)
36a1c56c
 	out, _ = dockerCmd(c, "volume", "inspect", "test")
 
 	type vol struct {
 		Status map[string]string
 	}
 	var st []vol
 
 	c.Assert(json.Unmarshal([]byte(out), &st), checker.IsNil)
 	c.Assert(st, checker.HasLen, 1)
 	c.Assert(st[0].Status, checker.HasLen, 1, check.Commentf("%v", st[0]))
 	c.Assert(st[0].Status["Hello"], checker.Equals, "world", check.Commentf("%v", st[0].Status))
d3eca445
 }
00ec6102
 
51c0c621
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverWithDaemonRestart(c *check.C) {
6a0bdffc
 	dockerCmd(c, "volume", "create", "-d", volumePluginName, "abc1")
c502fb49
 	s.d.Restart(c)
00ec6102
 
928bfd07
 	dockerCmd(c, "run", "--name=test", "-v", "abc1:/foo", "busybox", "true")
00ec6102
 	var mounts []types.MountPoint
c778f4b9
 	inspectFieldAndUnmarshall(c, "test", "Mounts", &mounts)
00ec6102
 	c.Assert(mounts, checker.HasLen, 1)
6a0bdffc
 	c.Assert(mounts[0].Driver, checker.Equals, volumePluginName)
00ec6102
 }
96c79a19
 
 // Ensures that the daemon handles when the plugin responds to a `Get` request with a null volume and a null error.
 // Prior the daemon would panic in this scenario.
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverGetEmptyResponse(c *check.C) {
c502fb49
 	s.d.Start(c)
88ea43d2
 
6a0bdffc
 	out, err := s.d.Cmd("volume", "create", "-d", volumePluginName, "abc2", "--opt", "ninja=1")
88ea43d2
 	c.Assert(err, checker.IsNil, check.Commentf(out))
 
 	out, err = s.d.Cmd("volume", "inspect", "abc2")
96c79a19
 	c.Assert(err, checker.NotNil, check.Commentf(out))
 	c.Assert(out, checker.Contains, "No such volume")
 }
9e6b1852
 
 // Ensure only cached paths are used in volume list to prevent N+1 calls to `VolumeDriver.Path`
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverPathCalls(c *check.C) {
c502fb49
 	s.d.Start(c)
9e6b1852
 	c.Assert(s.ec.paths, checker.Equals, 0)
 
ba3f0bf0
 	out, err := s.d.Cmd("volume", "create", "test", "--driver=test-external-volume-driver")
9e6b1852
 	c.Assert(err, checker.IsNil, check.Commentf(out))
 	c.Assert(s.ec.paths, checker.Equals, 1)
 
 	out, err = s.d.Cmd("volume", "ls")
 	c.Assert(err, checker.IsNil, check.Commentf(out))
 	c.Assert(s.ec.paths, checker.Equals, 1)
 
 	out, err = s.d.Cmd("volume", "inspect", "--format='{{.Mountpoint}}'", "test")
 	c.Assert(err, checker.IsNil, check.Commentf(out))
 	c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "")
 	c.Assert(s.ec.paths, checker.Equals, 1)
 }
2b6bc294
 
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverMountID(c *check.C) {
c502fb49
 	s.d.StartWithBusybox(c)
2b6bc294
 
6a0bdffc
 	out, err := s.d.Cmd("run", "--rm", "-v", "external-volume-test:/tmp/external-volume-test", "--volume-driver", volumePluginName, "busybox:latest", "cat", "/tmp/external-volume-test/test")
2b6bc294
 	c.Assert(err, checker.IsNil, check.Commentf(out))
 	c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "")
 }
2f40b1b2
 
 // Check that VolumeDriver.Capabilities gets called, and only called once
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverCapabilities(c *check.C) {
c502fb49
 	s.d.Start(c)
2f40b1b2
 	c.Assert(s.ec.caps, checker.Equals, 0)
 
 	for i := 0; i < 3; i++ {
6a0bdffc
 		out, err := s.d.Cmd("volume", "create", "-d", volumePluginName, fmt.Sprintf("test%d", i))
2f40b1b2
 		c.Assert(err, checker.IsNil, check.Commentf(out))
 		c.Assert(s.ec.caps, checker.Equals, 1)
 		out, err = s.d.Cmd("volume", "inspect", "--format={{.Scope}}", fmt.Sprintf("test%d", i))
 		c.Assert(err, checker.IsNil)
 		c.Assert(strings.TrimSpace(out), checker.Equals, volume.GlobalScope)
 	}
 }
6a0bdffc
 
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverOutOfBandDelete(c *check.C) {
 	driverName := stringid.GenerateNonCryptoID()
 	p := newVolumePlugin(c, driverName)
 	defer p.Close()
 
c502fb49
 	s.d.StartWithBusybox(c)
6a0bdffc
 
 	out, err := s.d.Cmd("volume", "create", "-d", driverName, "--name", "test")
 	c.Assert(err, checker.IsNil, check.Commentf(out))
 
 	out, err = s.d.Cmd("volume", "create", "-d", "local", "--name", "test")
 	c.Assert(err, checker.NotNil, check.Commentf(out))
 	c.Assert(out, checker.Contains, "volume named test already exists")
 
 	// simulate out of band volume deletion on plugin level
 	delete(p.vols, "test")
 
d8ce4a6e
 	// test re-create with same driver
 	out, err = s.d.Cmd("volume", "create", "-d", driverName, "--opt", "foo=bar", "--name", "test")
 	c.Assert(err, checker.IsNil, check.Commentf(out))
 	out, err = s.d.Cmd("volume", "inspect", "test")
 	c.Assert(err, checker.IsNil, check.Commentf(out))
 
 	var vs []types.Volume
 	err = json.Unmarshal([]byte(out), &vs)
 	c.Assert(err, checker.IsNil)
 	c.Assert(vs, checker.HasLen, 1)
 	c.Assert(vs[0].Driver, checker.Equals, driverName)
 	c.Assert(vs[0].Options, checker.NotNil)
 	c.Assert(vs[0].Options["foo"], checker.Equals, "bar")
 	c.Assert(vs[0].Driver, checker.Equals, driverName)
 
 	// simulate out of band volume deletion on plugin level
 	delete(p.vols, "test")
 
 	// test create with different driver
6a0bdffc
 	out, err = s.d.Cmd("volume", "create", "-d", "local", "--name", "test")
 	c.Assert(err, checker.IsNil, check.Commentf(out))
d8ce4a6e
 
 	out, err = s.d.Cmd("volume", "inspect", "test")
 	c.Assert(err, checker.IsNil, check.Commentf(out))
 	vs = nil
 	err = json.Unmarshal([]byte(out), &vs)
 	c.Assert(err, checker.IsNil)
 	c.Assert(vs, checker.HasLen, 1)
 	c.Assert(vs[0].Options, checker.HasLen, 0)
 	c.Assert(vs[0].Driver, checker.Equals, "local")
6a0bdffc
 }
9a2d0bc3
 
 func (s *DockerExternalVolumeSuite) TestExternalVolumeDriverUnmountOnMountFail(c *check.C) {
c502fb49
 	s.d.StartWithBusybox(c)
9a2d0bc3
 	s.d.Cmd("volume", "create", "-d", "test-external-volume-driver", "--opt=invalidOption=1", "--name=testumount")
 
 	out, _ := s.d.Cmd("run", "-v", "testumount:/foo", "busybox", "true")
 	c.Assert(s.ec.unmounts, checker.Equals, 0, check.Commentf(out))
 	out, _ = s.d.Cmd("run", "-w", "/foo", "-v", "testumount:/foo", "busybox", "true")
 	c.Assert(s.ec.unmounts, checker.Equals, 0, check.Commentf(out))
 }